Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh dependency inspector_protocol for Python 3 compatibility #25808

Closed
cclauss opened this issue Jan 30, 2019 · 3 comments
Closed

Refresh dependency inspector_protocol for Python 3 compatibility #25808

cclauss opened this issue Jan 30, 2019 · 3 comments

Comments

@cclauss
Copy link
Contributor

cclauss commented Jan 30, 2019

  • Version: all
  • Platform: all
  • Subsystem: inspector_protocol

As discussed in #24512 @bmsdave and @thefourtheye have successfully landed Python 3 syntax error fixes into upstream. This is a mutually beneficial way that we give back to the projects that we rely on. Given this progress, we should now sync with upstream to continue the process of eliminating Python 3 syntax errors from our codebase.
@cclauss cclauss mentioned this issue Jan 30, 2019
Closed
63 tasks
@targos targos self-assigned this Jan 30, 2019
@cclauss
Copy link
Contributor Author

cclauss commented Feb 16, 2019

@targos Are we progressing on this issue?

@targos
Copy link
Member

targos commented Feb 16, 2019

@cclauss thanks for the reminder! I have a wip branch to update our copy of inspector_protocol but it need a bit more work (adapt our C++ code to the changes).

@targos targos mentioned this issue Feb 16, 2019
Closed
@targos
Copy link
Member

targos commented Feb 16, 2019

I opened #26154. I can hopefully come back to it next week.

targos added a commit to targos/node that referenced this issue Feb 22, 2019
@targos
tools: update inspector_protocol to f67ec518
13e9fe3 
Fixes: nodejs#25808
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+/f67ec5180f476830e839226b5ca948e43070fdab
@pavelfeldman pavelfeldman mentioned this issue Feb 25, 2019
Merged
targos pushed a commit that referenced this issue Mar 4, 2019
@pavelfeldman @targos
tools: roll inspector_protocol to f67ec5
3232d42 
Fixes: #25808
refack pushed a commit to pavelfeldman/node that referenced this issue Mar 4, 2019
@pavelfeldman @refack
tools: roll inspector_protocol to f67ec5
d775d74 
Fixes: nodejs#25808

PR-URL: nodejs#26303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this issue Mar 12, 2019
@pavelfeldman @BridgeAR
tools: roll inspector_protocol to f67ec5
d841a89 
Fixes: nodejs#25808

PR-URL: nodejs#26303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
BethGriggs pushed a commit that referenced this issue Apr 16, 2019
@pavelfeldman @BethGriggs
tools: roll inspector_protocol to f67ec5
4819296 
Fixes: #25808

PR-URL: #26303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@targos targos removed their assignment Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@targos @cclauss