Skip to content

tools: need to upgrade tools/cpp_lint.py to be Python 3 compatible #25760

Closed
@cclauss

Description

Similar to #7462 but for Python 3 compatibility @bnoordhuis @thefourtheye

Upstream could be either:

Discovered via #25759 --> https://travis-ci.com/nodejs/node/jobs/173399622#L498

Running C++ linter on addon docs...
Traceback (most recent call last):
  File "tools/cpplint.py", line 6526, in <module>
    main()
  File "tools/cpplint.py", line 6510, in main
    ProcessFile(filename.decode('utf-8'), _cpplint_state.verbose_level)
AttributeError: 'str' object has no attribute 'decode'
  • Version:
  • Platform:
  • Subsystem:

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions