Skip to content

Investigate flaky test-fs-realpath-pipe #25070

Closed
Closed
Investigate flaky test-fs-realpath-pipe#25070
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.

Description

@Trott
Trott
opened on Dec 16, 2018

Looks like the same bug causing myriad other CI failures.

https://ci.nodejs.org/job/node-test-commit-linux-containered/9452/nodes=ubuntu1604_sharedlibs_zlib_x64/console

test-digitalocean-ubuntu1604_sharedlibs_container-x64-1

12:49:16 not ok 686 parallel/test-fs-realpath-pipe
12:49:16   ---
12:49:16   duration_ms: 0.966
12:49:16   severity: fail
12:49:16   exitcode: 1
12:49:16   stack: |-
12:49:16     assert.js:86
12:49:16       throw new AssertionError(obj);
12:49:16       ^
12:49:16     
12:49:16     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
12:49:16     
12:49:16     null !== 2
12:49:16     
12:49:16         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-fs-realpath-pipe.js:29:10)
12:49:16         at Module._compile (internal/modules/cjs/loader.js:718:30)
12:49:16         at Object.Module._extensions..js (internal/modules/cjs/loader.js:729:10)
12:49:16         at Module.load (internal/modules/cjs/loader.js:617:32)
12:49:16         at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
12:49:16         at Function.Module._load (internal/modules/cjs/loader.js:552:3)
12:49:16         at Function.Module.runMain (internal/modules/cjs/loader.js:771:12)
12:49:16         at executeUserCode (internal/bootstrap/node.js:318:15)
12:49:16         at startExecution (internal/bootstrap/node.js:252:3)
12:49:16         at startup (internal/bootstrap/node.js:203:3)
12:49:16   ...

Activity

  1. Trott
    added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Dec 16, 2018

  2. Trott commented on Dec 18, 2018

    @Trott
    Trott
    on Dec 18, 2018
    MemberAuthor

    Still happening, but infrequently enough that I'm comfortable not marking it flaky and seeing if whatever combination of things fixes #25007 fixes this too.

    Recent example:

    https://ci.nodejs.org/job/node-test-commit-linux-containered/9529/nodes=ubuntu1604_sharedlibs_withoutintl_x64/console

    test-digitalocean-ubuntu1604_sharedlibs_container-x64-10

    01:56:47 not ok 690 parallel/test-fs-realpath-pipe
01:56:47   ---
01:56:47   duration_ms: 0.410
01:56:47   severity: fail
01:56:47   exitcode: 1
01:56:47   stack: |-
01:56:47     assert.js:86
01:56:47       throw new AssertionError(obj);
01:56:47       ^
01:56:47     
01:56:47     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
01:56:47     
01:56:47     null !== 2
01:56:47     
01:56:47         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-fs-realpath-pipe.js:29:10)
01:56:47         at Module._compile (internal/modules/cjs/loader.js:718:30)
01:56:47         at Object.Module._extensions..js (internal/modules/cjs/loader.js:729:10)
01:56:47         at Module.load (internal/modules/cjs/loader.js:617:32)
01:56:47         at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
01:56:47         at Function.Module._load (internal/modules/cjs/loader.js:552:3)
01:56:47         at Function.Module.runMain (internal/modules/cjs/loader.js:771:12)
01:56:47         at executeUserCode (internal/bootstrap/node.js:318:15)
01:56:47         at startExecution (internal/bootstrap/node.js:252:3)
01:56:47         at startup (internal/bootstrap/node.js:203:3)
01:56:47   ...

  3. richardlau commented on Dec 21, 2018

    @richardlau
    richardlau
    on Dec 21, 2018
    Member

    And again: https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos7-64-gcc6/24226/testReport/junit/(root)/tes/parallel_test_fs_realpath_pipe/

  4. ZYSzys commented on Jan 8, 2019

    @ZYSzys
    ZYSzys
    on Jan 8, 2019
    Member

    +1 here: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/9094/testReport/junit/(root)/test/parallel_test_fs_realpath_pipe/

    assert.js:86
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

null !== 2

    at Object.<anonymous> (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-fs-realpath-pipe.js:29:10)
    at Module._compile (internal/modules/cjs/loader.js:718:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:729:10)
    at Module.load (internal/modules/cjs/loader.js:617:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
    at Function.Module._load (internal/modules/cjs/loader.js:552:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:771:12)
    at executeUserCode (internal/bootstrap/node.js:435:15)
    at startExecution (internal/bootstrap/node.js:372:3)

  5. gireeshpunathil commented on Jan 10, 2019

    @gireeshpunathil
    gireeshpunathil
    on Jan 10, 2019
    Member

    again, recreatable in freebsd:

    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

null !== 2

    at Object.<anonymous> (test/parallel/test-fs-realpath-pipe.js:29:10)
    at Module._compile (internal/modules/cjs/loader.js:718:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:729:10)
    at Module.load (internal/modules/cjs/loader.js:617:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
    at Function.Module._load (internal/modules/cjs/loader.js:552:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:771:12)
    at executeUserCode (internal/bootstrap/node.js:318:15)
    at startExecution (internal/bootstrap/node.js:252:3)
    at startup (internal/bootstrap/node.js:203:3)

    (gdb) where
#0  0x000000080323d277 in pthread_mutex_destroy () from /lib/libthr.so.3
#1  0x000000080323c7e6 in pthread_mutex_lock () from /lib/libthr.so.3
#2  0x000000000145b86d in v8::platform::tracing::TracingController::GetCategoryGroupEnabledInternal ()
#3  0x0000000000e60316 in v8::internal::CancelableLambdaTask<v8::internal::ArrayBufferCollector::FreeAllocations()::$_0>::RunInternal ()
#4  0x0000000000980fb6 in node::(anonymous namespace)::PlatformWorkerThread ()
#5  0x0000000803235c06 in pthread_create () from /lib/libthr.so.3
#6  0x0000000000000000 in ?? ()
(gdb) thr 2
[Switching to thread 2 (process 101173)]#0  0x0000000803516ff4 in realloc () from /lib/libc.so.7
(gdb) where
#0  0x0000000803516ff4 in realloc () from /lib/libc.so.7
#1  0x00000008035175b1 in free () from /lib/libc.so.7
#2  0x00000000008fdebd in std::__1::__tree<...> ::destroy ()
#3  0x00000000008fdec9 in std::__1::__tree<...>::destroy ()
#4  0x00000000008fdebd in std::__1::__tree<...>::destroy ()
#5  0x00000000008fdebd in std::__1::__tree<... >::destroy ()
#6  0x00000000008fdec9 in std::__1::__tree<... >::destroy ()
#7  0x00000000008fc5f3 in node::native_module::NativeModuleLoader::~NativeModuleLoader ()
#8  0x0000000803591911 in __cxa_finalize () from /lib/libc.so.7
#9  0x000000080351f001 in exit () from /lib/libc.so.7
#10 0x00000000008d9231 in node::Environment::Exit ()
#11 0x00000000008f986e in node::Exit ()
#12 0x0000000000b2a148 in v8::internal::FunctionCallbackArguments::Call ()
#13 0x0000000000b2974d in v8::internal::(anonymous namespace)::HandleApiCallHelper<false> ()
#14 0x0000000000b28f17 in v8::internal::Builtin_Impl_HandleApiCall ()
#15 0x000000000171218e in Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_NoBuiltinExit ()
...
(gdb)

    and matches all symptoms from #25007 , potential fix in #25061

  6. gireeshpunathil commented on Jan 30, 2019

    @gireeshpunathil
    gireeshpunathil
    on Jan 30, 2019
    Member

    the test is active for the last one week with no failures, so as expected #25061 has fixed the underlying issue. Closing.

  7. gireeshpunathil
    closed this as completedon Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions