Skip to content

test: more tests for PKCS#8 private keys #24928

Closed
Closed
test: more tests for PKCS#8 private keys#24928
Labels
cryptoIssues and PRs related to the crypto subsystem.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@bnoordhuis
bnoordhuis
opened on Dec 9, 2018

We currently lack coverage for unencrypted PKCS#8 private keys (-----BEGIN PRIVATE KEY-----) with the sole exception of test/fixtures/foafssl.key used in test/parallel/test-https-foafssl.js.

Compare PKCS#1 private keys (-----BEGIN RSA PRIVATE KEY-----) for which we have ample coverage.

I count three tests that cover encrypted PKCS#8 keys (-----BEGIN ENCRYPTED PRIVATE KEY-----):

test/parallel/test-tls-passphrase.js
test/parallel/test-crypto-rsa-dsa.js
test/parallel/test-crypto-rsa-dsa.js

For unencrypted PKCS#8, it would be nice to have tests for at least RSA and DSA, with and without PEM attributes for bonus points. See test/fixtures/foafssl.key for an example of attributes.

cc @sam-github - possibly relevant to your interests

Activity

  1. bnoordhuis
    added
    help wantedIssues that need assistance from volunteers or PRs that need help to proceed.
    cryptoIssues and PRs related to the crypto subsystem.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Dec 9, 2018

  2. uttampawar commented on Jan 9, 2019

    @uttampawar
    uttampawar
    on Jan 9, 2019
    Contributor

    @bnoordhuis If you can be a mentor and guide me, I would like to help out on this issue.

  3. bnoordhuis commented on Jan 10, 2019

    @bnoordhuis
    bnoordhuis
    on Jan 10, 2019
    MemberAuthor

    @uttampawar Thanks. Just ask questions and I'll try to answer them.

  4. bmsdave commented on Feb 7, 2019

    @bmsdave
    bmsdave
    on Feb 7, 2019
    Contributor

    @uttampawar
    Hi! Do you need help with this task?

  5. sasurau4 commented on Mar 25, 2019

    @sasurau4
    sasurau4
    on Mar 25, 2019
    Contributor

    Can I work on this issue?

  6. danbev
    added a commit that references this issue on Mar 28, 2019

    test: add test about unencrypted PKCS#8 private key for RSA

    85546c2
  7. targos
    added 4 commits that reference this issue on Mar 28, 2019

    test: add test about unencrypted PKCS#8 private key for RSA

    766d286

    test: add test about unencrypted PKCS#8 private key for RSA

    0a772b8

    test: add test about unencrypted PKCS#8 private key for RSA

    80e845e
  8. BethGriggs
    added a commit that references this issue on Apr 5, 2019

    test: add test about unencrypted PKCS#8 private key for RSA

    2fe8cc6
  9. MylesBorins
    added 2 commits that reference this issue on May 16, 2019

    test: add test about unencrypted PKCS#8 private key for RSA

    3ac2e3e

    test: add test about unencrypted PKCS#8 private key for RSA

    d22b913
  10. trivikr
    added
    Hacktoberfest
    on Oct 1, 2019
  11. Trott
    removed
    Hacktoberfest
    on Nov 3, 2019

  12. dhuang612 commented on Nov 20, 2019

    @dhuang612
    dhuang612
    on Nov 20, 2019

    Hi,

    Is this available to work on?

  13. tniessen commented on Nov 20, 2019

    @tniessen
    tniessen
    on Nov 20, 2019
    Member

    @bnoordhuis Is this still pending? The C++ coverage seems to be pretty good around key parsing, but it does not necessarily reflect all possible inputs.

  14. bnoordhuis commented on Nov 22, 2019

    @bnoordhuis
    bnoordhuis
    on Nov 22, 2019
    MemberAuthor

    Yes, 85546c2 resolves this - it should have had a Fixes: tag, not a Refs: tag. I'll close this out, thanks.

  15. bnoordhuis
    closed this as completedon Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cryptoIssues and PRs related to the crypto subsystem.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions