Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max header size of 8KB is a breaking change #24731

Closed
ValentinH opened this issue Nov 29, 2018 · 2 comments
Closed

Max header size of 8KB is a breaking change #24731

ValentinH opened this issue Nov 29, 2018 · 2 comments
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. http Issues or PRs related to the http subsystem.

Comments

@ValentinH
Copy link

ValentinH commented Nov 29, 2018 •
edited
Loading

We have just noticed an issue in production due to the latest Security release, especially this commit: a8532d4d23

On our website, we have pretty big cookies in some scenarios (it might not be good indeed) and we have been facing many 400 http errors since yesterday.

After investigation, we noticed that the 8KB maximum size was the issue. In my opinion, this is a breaking change.

What do you think?
@bnoordhuis
Copy link
Member

Duplicate of #24692, please see that issue. See also #24693.

@bnoordhuis bnoordhuis added duplicate Issues and PRs that are duplicates of other issues or PRs. http Issues or PRs related to the http subsystem. labels Nov 29, 2018
@ValentinH
Copy link
Author

Sorry for this and thanks for the quick answer :)

@katedee katedee mentioned this issue Jul 24, 2019
Merged
katedee added a commit to cds-snc/cra-claim-tax-benefits that referenced this issue Jul 24, 2019
@katedee
bump header size for node
9aa3aad 
Previously we were getting either a generic 400 error every once in awhile, or on my end, the more specific 431 error.

Node before had a default header size allowance of 80kb, but changed it to 8kb (nodejs/node#24731). This was causing issues for our app, and forcing us to clear cache regularly. For our purposes now, I've bumped that limit up to 40kb.
tecfu added a commit to tecfu/koa that referenced this issue Dec 26, 2019
@tecfu
Feat: Add maxHeaderSize to fix breaking change in node. Info: nodejs/…
52042a0 
…node#24731
@tecfu tecfu mentioned this issue Dec 26, 2019
Closed
@hingermayank hingermayank mentioned this issue Jan 23, 2020
Closed
@593769290 593769290 mentioned this issue Feb 8, 2020
Closed
@ScooterDelta ScooterDelta mentioned this issue May 18, 2020
Closed
@southpolesteve southpolesteve mentioned this issue Jul 2, 2020
Closed
@thekid thekid mentioned this issue Apr 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bnoordhuis @ValentinH