Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: install headers and iojs.lib on windows #245

Closed
piscisaureus opened this issue Jan 7, 2015 · 4 comments
Closed

installer: install headers and iojs.lib on windows #245

piscisaureus opened this issue Jan 7, 2015 · 4 comments
Assignees
Labels
install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform.

Comments

@piscisaureus
Copy link
Contributor

No description provided.

@piscisaureus piscisaureus added this to the v1.0.0 milestone Jan 7, 2015
@rvagg
Copy link
Member

rvagg commented Jan 12, 2015

iojs.lib is being uploaded along with iojs.exe in the [nightlies](https://iojs.org/download/nightly/ with one departure from the way it's done on nodejs.org/dist/ - they are put in subdirectories, named win-x64 and win-x86, whereas on nodejs.org the 32-bit ones are dumped in the top level and there is an "x64" directory just for windows 64-bit.

Our source tarball is getting close to 20Mb now, it's already a pain to download this with node-gyp just for the headers, I'd like us to do a trimmed source for download, perhaps just what you need to build a binary, or just headers or some other combination of files that excludes the big unnecessary assets (and tests). I'm happy to put another process into the build pipeline if it's just a make target, currently we're doing make tar to get the source tarball.

@rvagg
Copy link
Member

rvagg commented Jan 12, 2015

iojs.lib is being uploaded along with iojs.exe in the nightlies with one departure from the way it's done on nodejs.org/dist/ - they are put in subdirectories, named win-x64 and win-x86, whereas on nodejs.org the 32-bit ones are dumped in the top level and there is an "x64" directory just for windows 64-bit.

Our source tarball is getting close to 20Mb now, it's already a pain to download this with node-gyp just for the headers, I'd like us to do a trimmed source for download, perhaps just what you need to build a binary, or just headers or some other combination of files that excludes the big unnecessary assets (and tests). I'm happy to put another process into the build pipeline if it's just a make target, currently we're doing make tar to get the source tarball.

@rvagg rvagg mentioned this issue Jan 12, 2015
14 tasks
@piscisaureus piscisaureus removed this from the v1.0.0 milestone Jan 14, 2015
@piscisaureus
Copy link
Contributor Author

This will slip for the v1.0.0 milestone.
The idea would be to just carry the public header files and node.lib, which should be enough to compile native addons. If we do that node-gyp won't have to download tarballs any longer.

That should add no more than 600kb (uncompressed) to the distribution.

@Fishrock123 Fishrock123 added the windows Issues and PRs related to the Windows platform. label Jan 22, 2015
@brendanashworth brendanashworth added the install Issues and PRs related to the installers. label Jul 18, 2015
@brendanashworth
Copy link
Contributor

.. hows the status, can this be closed now? iojs.lib is in /dist/, as well as the header files, afaik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

4 participants