Skip to content

flaky: test-stream-pipeline-http2 #24456

Closed
Closed
flaky: test-stream-pipeline-http2#24456
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.streamIssues and PRs related to Node.js streams.windowsIssues and PRs related to the Windows platform.

Description

@refack
refack
opened on Nov 17, 2018
  • Version: master
  • Platform: Windows 2008R2
  • Subsystem: cli

Activity

  1. refack
    added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    streamIssues and PRs related to Node.js streams.
    windowsIssues and PRs related to the Windows platform.
    on Nov 17, 2018

  2. Trott commented on Nov 18, 2018

    @Trott
    Trott
    on Nov 18, 2018
    Member

    Replicable locally. Move to sequential?

    $ tools/test.py --repeat 192 -j 96 test/parallel/test-stream-pipeline.js 
=== release test-stream-pipeline ===                    
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
=== release test-stream-pipeline ===                   
Path: parallel/test-stream-pipeline
Command: out/Release/node /Users/trott/io.js/test/parallel/test-stream-pipeline.js
--- TIMEOUT ---
[02:19|% 100|+ 168|-  24]: Done  
$

  3. refack commented on Nov 18, 2018

    @refack
    refack
    on Nov 18, 2018
    ContributorAuthor

    Does running with -j1 pass?

  4. Trott commented on Nov 18, 2018

    @Trott
    Trott
    on Nov 18, 2018
    Member

    Does running with -j1 pass?

    Yes.

    $ tools/test.py --repeat 192 -j 1 test/parallel/test-stream-pipeline.js 
[00:58|% 100|+ 192|-   0]: Done  
$

  5. refack commented on Nov 18, 2018

    @refack
    refack
    on Nov 18, 2018
    ContributorAuthor

    Since this was obsered on Windows2008R2
    -j8 - https://ci.nodejs.org/job/node-stress-single-test/2084/ ❌
    -j1 - https://ci.nodejs.org/job/node-stress-single-test/2085/ ❌

    Seems like "sequential"izing won't solve this.

  6. refack commented on Nov 19, 2018

    @refack
    refack
    on Nov 19, 2018
    ContributorAuthor

    Job: https://ci.nodejs.org/job/node-test-binary-windows/21717/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=1
    Worker: https://ci.nodejs.org/computer/test-rackspace-win2008r2-x64-6/

    15:42:10 not ok 409 parallel/test-stream-pipeline
15:42:10   ---
15:42:10   duration_ms: 120.88
15:42:10   severity: fail
15:42:10   exitcode: 1
15:42:10   stack: |-
15:42:10     timeout
15:42:10   ...

  7. Trott commented on Nov 24, 2018

    @Trott
    Trott
    on Nov 24, 2018
    Member

    Some more context from the -j1 job:

    11:04:29 not ok 1 parallel/test-stream-pipeline
11:04:29   ---
11:04:29   duration_ms: 120.160
11:04:29   severity: fail
11:04:29   exitcode: 1
11:04:29   stack: |-
11:04:29     timeout
11:04:29   ...
11:04:29 2   OK: 0   NOT OK: 2   TOTAL: 200
11:04:30 TAP version 13
11:04:30 1..1
11:04:30 ok 1 parallel/test-stream-pipeline
11:04:30   ---
11:04:30   duration_ms: 0.492
11:04:30   ...

    Seems like a race condition?

  8. Trott
    added a commit that references this issue on Nov 24, 2018

    test: split out http2 from test-stream-pipeline

    8bc2f8d

  9. Trott commented on Nov 24, 2018

    @Trott
    Trott
    on Nov 24, 2018
    Member

    #24631 is an attempt to diagnose this a bit by splitting the http2 stuff into a separate test.

  10. Trott
    added a commit that references this issue on Nov 25, 2018

    test: split out http2 from test-stream-pipeline

    8c0aa84
  11. Trott
    changed the title [-]flaky: test-stream-pipeline[/-] [+]flaky: test-stream-pipeline-http2[/+] on Nov 25, 2018

  12. Trott commented on Nov 25, 2018

    @Trott
    Trott
    on Nov 25, 2018
    Member

    Now that #24631 has landed, the problematic part of the test is in its own test file (test-stream-pipeline-http2.js) and marked as flaky. Leaving this issue open until the flakiness is resolved. /ping @nodejs/http2

  13. targos
    added a commit that references this issue on Nov 25, 2018

    test: split out http2 from test-stream-pipeline

    c27b948

  14. 9 remaining items

  15. Trott
    added a commit that references this issue on Dec 8, 2018

    Revert "stream: make `.destroy()` interact better with write queue"

    01afa9b

  16. addaleax commented on Dec 9, 2018

    @addaleax
    addaleax
    on Dec 9, 2018
    Member

    This should be addressed by #24926 :)

  17. Trott
    added a commit that references this issue on Dec 11, 2018

    stream: fix end-of-stream for HTTP/2

    83ec33b

  18. Trott commented on Dec 11, 2018

    @Trott
    Trott
    on Dec 11, 2018
    Member

    Fixed in 83ec33b

  19. Trott
    closed this as completedon Dec 11, 2018
  20. BethGriggs
    added a commit that references this issue on Dec 17, 2018

    stream: fix end-of-stream for HTTP/2

    39af61f
  21. refack
    added 2 commits that reference this issue on Jan 14, 2019

    test: split out http2 from test-stream-pipeline

    0a6a0d5

    stream: fix end-of-stream for HTTP/2

    c83cf24
  22. BethGriggs
    added 2 commits that reference this issue on Feb 11, 2019

    test: split out http2 from test-stream-pipeline

    5e3b34f

    stream: fix end-of-stream for HTTP/2

    bb8a65d
  23. BethGriggs
    added a commit that references this issue on Feb 20, 2019

    stream: fix end-of-stream for HTTP/2

    11287f8
  24. rvagg
    added 2 commits that reference this issue on Feb 28, 2019

    test: split out http2 from test-stream-pipeline

    964f822

    stream: fix end-of-stream for HTTP/2

    a838116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.streamIssues and PRs related to Node.js streams.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions