Skip to content

assert.deepEqual & post-ES5 Data Types e.g. Map, Set, Iterables, etc #2309

Closed
@timoxley

Description

@timoxley

Currently assert.deepEquals is ignorant of any new native data types introduced in ES6.

For example, this should probably throw, yet it does not:

assert.deepEqual(new Set([1, 2]), new Set([1]))

A good method might be to deepEqual against .keys() and .values().
deepEqual should also probably work with generic Iterables too.

Metadata

Metadata

Assignees

No one assigned

    Labels

    assertIssues and PRs related to the assert subsystem.feature requestIssues that request new features to be added to Node.js.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions