Skip to content

Create Buffer from Object missing null check #2194

Closed
@Cellule

Description

@Cellule

In next branch
If I run new Buffer() I get the error

TypeError: Unable to get property 'buffer' of undefined or null reference
   at fromObject (buffer.js:112:3)

When the error used to be

TypeError: must start with number, buffer, array or string
   at fromObject (buffer.js:109:5)

In fromObject the following check got lost in rework
https://github.com/nodejs/io.js/pull/1825/files#diff-196d056a936b6d2649721eb639e0442bL84
when buffer code went into lib/internal/buffer_new.js
https://github.com/nodejs/io.js/pull/1825/files#diff-c28ab5e2f9b7f2f9890ac44e7370af59R107

  if (obj == null)
    throw new TypeError('must start with number, buffer, array or string');

  if (obj instanceof ArrayBuffer) {
    return binding.createFromArrayBuffer(obj);
  }

Metadata

Metadata

Assignees

No one assigned

    Labels

    bufferIssues and PRs related to the buffer subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions