-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport request: Xcode 10-related fixes #21299
Comments
All three are in 10.x-staging branch, although only two of the three appear to have made it into today's 10.x release. I'll follow up on the other branches. |
Landed all three on v9.x-staging. |
I just confirmed that all three commits land cleanly on v8.x-staging. Can someone from @nodejs/lts land them? |
a9e70d7 and 400df22 land cleanly on v6.x-staging. The other one is backported in https://ci.nodejs.org/job/node-test-pull-request/15430/. @nodejs/lts, if you could cherry-pick those two commits and land that backport commit, this issue can be closed. |
For reference, the backport PR for v6.x is #21301. |
landed in v6.x-staging in 8442d2a...a5d1ab3 I'm closing the issue as there is nothing more actionable, aside from getting things out in a release. This will definitely go out in the next 8.x but it isn't clear if it will make it to a 6.x release. At the very least this is provided in the staging branch to make it easier for people to float |
Also, thanks @mistydemeo so much for not only fixing this but seeing through that it would land in all the release lines. I very much appreciate that level a commitment to fixing the problem |
There are three commits in the master branch which fix running configure and compiling on double-digit Xcode versions. It'd be very helpful to get these backported into any branches that are still getting new releases! The commits are:
a9e70d7
641d4a4
400df22
In addition, 400df22 was missed when the other two were backported to branch
v10.x
.cc @Trott
The text was updated successfully, but these errors were encountered: