Skip to content

ReadableAsyncIterator error not handled #20347

Closed
@fabiancook

Description

@fabiancook

It appears that this[kError] could never be anything other than null, as in onError, iter.error = is used rather than iter[kError] = , this means in next, this[kError] will always be null, and the error will always be sitting there.

It looks like that if the error occurs while waiting for the next read it will invoke this[kLastReject], at any other point it will go unnoticed.

I can't see anywhere iter.error is used, which is why I am making this issue

If I'm misdirected in what I am seeing, please do correct me 😀

Relevant link: https://github.com/nodejs/node/blob/master/lib/internal/streams/async_iterator.js#L61

Metadata

Metadata

Assignees

No one assigned

    Labels

    errorsIssues and PRs related to JavaScript errors originated in Node.js core.promisesIssues and PRs related to ECMAScript promises.streamIssues and PRs related to the stream subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions