test: Errors when running tests as root `sudo make test`

[dsinecos]

• Version: master
• Platform: 16.04.1, Ubuntu
• Subsystem: test

When running tests as root, sudo make test I get the following errors

Error 1 -

=== release test-child-process-spawnsync-validation-errors ===                 
Path: parallel/test-child-process-spawnsync-validation-errors
Mismatched innerFn function calls. Expected exactly 62, actual 42.
    at Object.exports.mustCall (/home/divyanshu/programming/node/test/common/index.js:427:10)
    at Object.expectsError (/home/divyanshu/programming/node/test/common/index.js:717:18)
    at Object.<anonymous> (/home/divyanshu/programming/node/test/parallel/test-child-process-spawnsync-validation-errors.js:14:12)
    at Module._compile (internal/modules/cjs/loader.js:677:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:688:10)
    at Module.load (internal/modules/cjs/loader.js:588:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:527:12)
    at Function.Module._load (internal/modules/cjs/loader.js:519:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:718:10)
Command: out/Release/node /home/divyanshu/programming/node/test/parallel/test-child-process-spawnsync-validation-errors.js

Error 2

=== release test-fs-access ===                                                 
Path: parallel/test-fs-access
fs.js:110
    throw err;
    ^

Error: EACCES: permission denied, access '/home/divyanshu/programming/node/test/parallel/test-fs-access.js'
    at Object.fs.accessSync (fs.js:200:3)
    at Object.<anonymous> (/home/divyanshu/programming/node/test/parallel/test-fs-access.js:116:4)
    at Module._compile (internal/modules/cjs/loader.js:677:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:688:10)
    at Module.load (internal/modules/cjs/loader.js:588:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:527:12)
    at Function.Module._load (internal/modules/cjs/loader.js:519:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:718:10)
    at startup (internal/bootstrap/node.js:225:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:572:3)
Command: out/Release/node /home/divyanshu/programming/node/test/parallel/test-fs-access.js

Error 3

=== release test-process-geteuid-getegid ===                                   
Path: parallel/test-process-geteuid-getegid
/home/divyanshu/programming/node/test/parallel/test-process-geteuid-getegid.js:41
process.setegid('nobody');
        ^

Error: setegid group id does not exist
    at Object.<anonymous> (/home/divyanshu/programming/node/test/parallel/test-process-geteuid-getegid.js:41:9)
    at Module._compile (internal/modules/cjs/loader.js:677:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:688:10)
    at Module.load (internal/modules/cjs/loader.js:588:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:527:12)
    at Function.Module._load (internal/modules/cjs/loader.js:519:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:718:10)
    at startup (internal/bootstrap/node.js:225:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:572:3)
Command: out/Release/node /home/divyanshu/programming/node/test/parallel/test-process-geteuid-getegid.js

Error 4

=== release test-process-setuid-setgid ===                                     
Path: parallel/test-process-setuid-setgid
/home/divyanshu/programming/node/test/parallel/test-process-setuid-setgid.js:60
process.setgid('nobody');
        ^

Error: setgid group id does not exist
    at Object.<anonymous> (/home/divyanshu/programming/node/test/parallel/test-process-setuid-setgid.js:60:9)
    at Module._compile (internal/modules/cjs/loader.js:677:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:688:10)
    at Module.load (internal/modules/cjs/loader.js:588:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:527:12)
    at Function.Module._load (internal/modules/cjs/loader.js:519:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:718:10)
    at startup (internal/bootstrap/node.js:225:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:572:3)
Command: out/Release/node /home/divyanshu/programming/node/test/parallel/test-process-setuid-setgid.js

Error 1 is covered in Issue 19371

Error 3 and Error 4

The lines that throw these errors in the respective files

• In test-process-geteuid-getegid.js - process.setegid('nobody');
• In test-process-setuid-setgid.js - process.setgid('nobody');

On reading further, I figured that this is because the standard nobody group in UNIX systems is named nogroup in Ubuntu.

When I changed the lines which were throwing errors to the following - which checks if nobody group does not exist on the UNIX system it tries to set the group to nogroup before throwing an error

try {
  process.setegid('nobody');
} catch (err) {
  if (err.message !== 'setegid group id does not exist') {
    throw err;
  } else {
    process.setegid('nogroup');
  }
}

and

try {
  process.setgid('nobody');
} catch (err) {
  if (err.message !== 'setgid group id does not exist') {
    throw err;
  } else {
    process.setgid('nogroup');
  }
}

respectively in the two files, Errors 3 and 4 were resolved

I'd like to work on Errors 3 and 4 and if the changes I have made make sense I'd like to submit a PR for it

[gireeshpunathil]

@dsinecos - as you already pointed out, the first failure is covered under #19554 . Please go ahead for the remaining! Let me know if you need any help with that!

[dsinecos]

@gireeshpunathil I have resolved errors 3 and 4 both relating to group id does not exist Can i submit a PR for that?

I was thinking to open another issue for Error 2 Error: EACCES: permission denied, access '/home/divyanshu/programming/node/test/parallel/test-fs-access.js' and work on that separately?

Or should I submit a single PR for all three?

[gireeshpunathil]

I suggest one PR per test file, for the benefit of isolation between changes.

[dsinecos]

@gireeshpunathil

I ran sudo make test to verify that the error 2 is resolved after I add my code.

However, if I run make test after sudo make test I get a bunch of EACCES permission denied errors on files, because they were created with root privileges when I ran sudo make test.

If I run only make test the error I'm working on won't occur so I need to run sudo make test to verify the error I'm working on is resolved.

Should I submit the PR as long as that error is resolved in sudo make test?

[gireeshpunathil]

as long as make test with normal user and independent run on the modified test as root and non-root (node test/paralel/x.js) pass, we should be good!

[dsinecos]

Got your point on how to test this PR, thanks :)

@gireeshpunathil Need some more help here, I think I messed up my build.

After I ran sudo make test I deleted the folders that had root permissions (test/.tmp.0 ..., test/addons/01_function_arguments ...), thinking that they would be recreated when I run make test (I had tried that earlier and it had worked) This time around though, I get errors eg.

Building addon /home/divyanshu/programming/node/test/addons/async-hello-world/
Makefile:329: recipe for target 'test/addons/.buildstamp' failed
make[1]: *** [test/addons/.buildstamp] Error 1
Makefile:242: recipe for target 'test' failed
make: *** [test] Error 2

Is there a way to start clean, but without having to refork and rebuild? I'd prefer not to refork and rebuild as there is another pull request active currently from the forked repo.

[gireeshpunathil]

• make clean and make test
  if that fails
• ./configure && make test
  if that too fails due to missing sources,
• git status will tell you the list of missing files, do git checkout on them and do a rebuild

[dsinecos]

I tried make clean but it gave EACCES permission denied errors, So I ran sudo make clean and then make test. That worked :)