Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster,test: failing cluster+inspector test when using port 65535 #18303

Closed
bnoordhuis opened this issue Jan 23, 2018 · 0 comments
Closed

cluster,test: failing cluster+inspector test when using port 65535 #18303

bnoordhuis opened this issue Jan 23, 2018 · 0 comments
Labels
cluster Issues and PRs related to the cluster subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Comments

@bnoordhuis
Copy link
Member

https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/11932/consoleText

not ok 2069 sequential/test-inspector-port-zero-cluster
  ---
  duration_ms: 0.911
  severity: fail
  stack: |-
    Debugger listening on ws://127.0.0.1:65535/a568d00d-197e-452f-9f5a-b49ad2103d28
    For help see https://nodejs.org/en/docs/inspector
    Debug port must be 0 or in range 1024 to 65535.
    Debug port must be 0 or in range 1024 to 65535.
    Debug port must be 0 or in range 1024 to 65535.
    { AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
    
      assert(ports.every((port) => port < 65536))
    
        at Promise.all.then.common.mustCall (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/sequential/test-inspector-port-zero-cluster.js:38:7)
        at /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/common/index.js:537:15
        at <anonymous>
        at process._tickCallback (internal/process/next_tick.js:120:7)
      generatedMessage: false,
      name: 'AssertionError [ERR_ASSERTION]',
      code: 'ERR_ASSERTION',
      actual: false,
      expected: true,
      operator: '==' }

Note the ws://127.0.0.1:65535/. The test randomly picked port 65535, then tries to spawn additional processes that bind to consecutive ports, which of course fails.

There are probably more tests that suffer the same issue but it's arguably also a bug in the cluster module because it happily picks ports > 65535 for workers.

@bnoordhuis bnoordhuis added cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jan 23, 2018
santigimeno added a commit to santigimeno/node that referenced this issue Feb 18, 2018
Make sure that inspector ports in cluster are inside the valid range:
`[1024, 65535]`.
Fix flaky `test-inspector-port-zero-cluster`.

Fixes: nodejs#18303
addaleax pushed a commit to addaleax/node that referenced this issue Feb 26, 2018
Make sure that inspector ports in cluster are inside the valid range:
`[1024, 65535]`.
Fixes flaky `test-inspector-port-zero-cluster`.

PR-URL: nodejs#18696
Fixes: nodejs#18303
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this issue Feb 26, 2018
Make sure that inspector ports in cluster are inside the valid range:
`[1024, 65535]`.
Fixes flaky `test-inspector-port-zero-cluster`.

PR-URL: #18696
Fixes: #18303
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this issue Apr 13, 2018
Make sure that inspector ports in cluster are inside the valid range:
`[1024, 65535]`.
Fixes flaky `test-inspector-port-zero-cluster`.

PR-URL: #18696
Fixes: #18303
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
Make sure that inspector ports in cluster are inside the valid range:
`[1024, 65535]`.
Fixes flaky `test-inspector-port-zero-cluster`.

PR-URL: nodejs#18696
Fixes: nodejs#18303
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant