-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repl: strange behaviour in the last nightlies on Windows #18189
Comments
@vsemozhetbyt @apapirovski Thanks, I’ll take a look! |
Fwiw, I cannot reproduce the exact problem as described by you, but printing a simple non-ASCII string like But yes, it seems like this is being triggered by #18019, and in released versions of Node this also doesn't quite work the way I'd expect it to: > fs.writeSync(1, 'Ö\n')
Ö
3 I guess that's happening because the default code page isn't expecting UTF-8? Thinking a bit harder about it, I think it's okay to just revert the changes to As a side note: We currently actually recommend |
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7. Fixes: nodejs#18189 Refs: nodejs#18019
FWIW, changing of a shell code page seems to not fix the issue: > chcp 65001
Active code page: 65001
> node.10.0.0.v8-6.3.20180116.nightly.exe
[1G [0J> [3G
> chcp 1252
Active code page: 1252
> node.10.0.0.v8-6.3.20180116.nightly.exe
�[1G�[0J> �[3G
> chcp 850
Active code page: 850
> node.10.0.0.v8-6.3.20180116.nightly.exe
←[1G←[0J> ←[3G
|
@vsemozhetbyt Can you try #18214 and see if you’re still seeing those issues? |
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7. Fixes: #18189 Refs: #18019 PR-URL: #18214 Fixes: #18189 Refs: #18019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7. Fixes: #18189 Refs: #18019 PR-URL: #18214 Fixes: #18189 Refs: #18019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7. Fixes: nodejs#18189 Refs: nodejs#18019 PR-URL: nodejs#18214 Fixes: nodejs#18189 Refs: nodejs#18019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7. Fixes: #18189 Refs: #18019 PR-URL: #18214 Fixes: #18189 Refs: #18019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
cmd.exe
shellSteps to reproduce:
Anomalies:
10.0.0 nightly 2018 01 13 screenshot:
10.0.0 nightly 2018 01 14–16 screenshot:
Not sure if this is reproducible in other OSs.
The text was updated successfully, but these errors were encountered: