Skip to content

Running Node.js benchmarks in the community CI #17359

Description

@gareth-ellis

Hello @nodejs/collaborators ,

The community benchmarking workgroup has been working to get an easy way to launch and test the impactof a PR using a subset of benchmarks, making use of the hardware that was donated by Intel.

We've had a number of people test this out, and now we're at the point where it would be useful (both for us from a testing/verification perspective, and for the rest of the community) to see more people trying this out.

We've documented the use in https://github.com/nodejs/benchmarking/blob/master/docs/core_benchmarks.md

So, the next time you have a PR that there is a concern whether it would impact performance (or even if you just want to give the benchmarks in the CI a go), take a look and report back.

If you run into issues, please tag @nodejs/benchmarking or raise an issue in the benchmarking repo.

Thanks!

Activity

  1. added
    metaIssues and PRs related to the general management of the project.
    on Nov 27, 2017
  2. added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Nov 28, 2017
  3. joyeecheung commented on Nov 28, 2017

    @joyeecheung
    Member

    BTW: #16557 is still open (the CI is using the test double for HTTP benchmarks because it does not have wrk/autocannon installed.), in case anyone wants to pick it up (I assigned that to myself but I've been a bit busy to tackle this).

  4. gareth-ellis commented on Nov 28, 2017

    @gareth-ellis
    MemberAuthor

    I can take a look - if there's issues like that in the future, tagging the benchmarking team would notify a larger group of people and so hopefully someone can look. I'll comment in that issue

  5. mhdawson commented on Jan 15, 2018

    @mhdawson
    Member

    The issue @joyeecheung mentioned should now be resolved.

  6. mhdawson commented on Jan 15, 2018

    @mhdawson
    Member

    I think its in place and being used closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.metaIssues and PRs related to the general management of the project.performanceIssues and PRs related to the performance of Node.js.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions