Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy-paste typo in the API doc of url.format(urlObject). #17294

Closed
pdkovacs opened this issue Nov 25, 2017 · 0 comments
Closed

Copy-paste typo in the API doc of url.format(urlObject). #17294

pdkovacs opened this issue Nov 25, 2017 · 0 comments

Comments

@pdkovacs
Copy link

  • Version: v9.2.0
  • Platform: All
  • Subsystem: Documentation

Copy-paste typo in the API doc of url.format(urlObject).

Actual:

If urlObject is not an object or a string, url.parse() will throw a TypeError.

Expected

If urlObject is not an object or a string, url.format() will throw a TypeError.
@pdkovacs pdkovacs mentioned this issue Nov 25, 2017
Closed
2 tasks
MylesBorins pushed a commit that referenced this issue Dec 12, 2017
@cxn-pkovacs @MylesBorins
doc: fix typo in api doc of url.format(urlObject)
0df88ce 
PR-URL: #17295
Fixes: #17294
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this issue Dec 12, 2017
@cxn-pkovacs @MylesBorins
doc: fix typo in api doc of url.format(urlObject)
524db29 
PR-URL: #17295
Fixes: #17294
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn pushed a commit that referenced this issue Dec 19, 2017
@cxn-pkovacs @gibfahn
doc: fix typo in api doc of url.format(urlObject)
10bf570 
PR-URL: #17295
Fixes: #17294
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn pushed a commit that referenced this issue Dec 19, 2017
@cxn-pkovacs @gibfahn
doc: fix typo in api doc of url.format(urlObject)
46dc241 
PR-URL: #17295
Fixes: #17294
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn pushed a commit that referenced this issue Dec 20, 2017
@cxn-pkovacs @gibfahn
doc: fix typo in api doc of url.format(urlObject)
ceab928 
PR-URL: #17295
Fixes: #17294
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: typo in api doc of url.format(urlObject)
1 participant
@pdkovacs