Shared Library build failing on v8.7.0

[BethGriggs]

• Version: 8.7.0
• Platform: Darwin, xLinux, and AIX
• Subsystem: shared, build

The shared library builds are failing on Darwin, xLinux, and AIX with the following error:

installing /Users/bethanycooks/node/node-v8.7.0-darwin-x64/lib/node_modules/npm/scripts/relocate.sh
installing /Users/bethanycooks/node/node-v8.7.0-darwin-x64/lib/node_modules/npm/scripts/update-authors.sh
symlinking ../lib/node_modules/npm/bin/npm-cli.js -> /Users/bethanycooks/node/node-v8.7.0-darwin-x64/bin/npm
Traceback (most recent call last):
  File "tools/install.py", line 226, in <module>
    run(sys.argv[:])
  File "tools/install.py", line 220, in run
    if cmd == 'install': return files(install)
  File "tools/install.py", line 156, in files
    if 'true' == variables.get('node_install_npm'): npm_files(action)
  File "tools/install.py", line 97, in npm_files
    try_symlink('../lib/node_modules/npm/bin/npm-cli.js', link_path)
  File "tools/install.py", line 36, in try_symlink
    os.symlink(source_path, link_path)
OSError: [Errno 2] No such file or directory
make[1]: *** [install] Error 1
make: *** [node-v8.7.0-darwin-x64.tar] Error 2

To reproduce:

git checkout v8.7.0
export CONFIG_FLAGS="--shared"
make -j8 clean binary

[bnoordhuis]

Does /Users/bethanycooks/node/node-v8.7.0-darwin-x64/bin exist?

[BethGriggs]

No it does not exist.

[gibfahn]

Sounds like an issue with install.py, maybe ed8c89a#diff-da64c76e85440e0f10e27fea8e8e5c9a ?

Can check by trying the build on v8.6.0.

[bnoordhuis]

Does this patch fix it?

diff --git a/tools/install.py b/tools/install.py
index d6793755cb..6be5a865a6 100755
--- a/tools/install.py
+++ b/tools/install.py
@@ -32,6 +32,7 @@ def try_unlink(path):
 
 def try_symlink(source_path, link_path):
   print 'symlinking %s -> %s' % (source_path, link_path)
+  try_mkdir_r(os.path.dirname(link_path))
   try_unlink(link_path)
   os.symlink(source_path, link_path)
 

[BethGriggs]

@bnoordhuis yes, that fixes the issue.

[bnoordhuis]

#16438