Skip to content

test-npm failing on master after introduction of initial async hooks implementation #13045

@mscdex

Description

@mscdex
  • Version: master
  • Platform: n/a
  • Subsystem: async_hooks

make test-npm is failing since #12892 (4a7233c) landed it seems. In particular, it appears that it's possible for a socket handle to not have an asyncReset function attached (perhaps something in npm or one of its dependencies are unsetting it?), causing a TypeError on this line.

After running across that issue, I spotted just a few lines below that that there is a bug waiting to happen on this line and this line because newSocket should be undefined if an error occurred.

I have not checked for other similar potential issues yet.

/cc @AndreasMadsen @addaleax @trevnorris

Metadata

Metadata

Assignees

Labels

async_hooksIssues and PRs related to the async hooks subsystem.confirmed-bugIssues with confirmed bugs.regressionIssues related to regressions.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions