Skip to content

'disconnect' event is not emitted on cluster.worker #1304

Closed
Closed
'disconnect' event is not emitted on cluster.worker#1304
Labels
clusterIssues and PRs related to the cluster subsystem.

Description

@Olegas
Olegas
opened on Mar 31, 2015

Demo app here: https://gist.github.com/Olegas/c2e5550911cbe8b96dae

Steps to reproduce:

  1. Start app, wait 10 sec
  2. App is terminated and log show the following lines
Master started
Worker started
Worker listening
Disconnecting worker
Cluster: worker is disconnected

Expected result:
Line Worker disconnected (from https://gist.github.com/Olegas/c2e5550911cbe8b96dae#file-demo-js-L26) is present in log as stated in docs: https://iojs.org/api/cluster.html#cluster_event_disconnect_1

If I change line 25 to cluster.worker.process.on('disconnect', ... it works fine.

Activity

  1. Fishrock123
    added
    clusterIssues and PRs related to the cluster subsystem.
    on Mar 31, 2015

  2. Olegas commented on Apr 1, 2015

    @Olegas
    Olegas
    on Apr 1, 2015
    ContributorAuthor

    Can we just add worker.emit('disconnect'); just above this line: https://github.com/iojs/io.js/blob/v1.x/lib/cluster.js#L510

  3. cjihrig commented on Apr 9, 2015

    @cjihrig
    cjihrig
    on Apr 9, 2015
    Contributor

    @Olegas that sounds correct to me. Currently, there is no parallel for this in the cluster child process worker. Do you want to open a PR, or should I?

  4. Olegas commented on Apr 9, 2015

    @Olegas
    Olegas
    on Apr 9, 2015
    ContributorAuthor

    I'll do

  5. brendanashworth
    added a commit that references this issue on May 8, 2015

    cluster: disconnect event not emitted correctly

    5883a59

  6. brendanashworth commented on May 8, 2015

    @brendanashworth
    brendanashworth
    on May 8, 2015
    Contributor

    Should be fixed as of 5883a59.

  7. brendanashworth
    closed this as completedon May 8, 2015
  8. Fishrock123
    added a commit that references this issue on May 19, 2015

    cluster: disconnect event not emitted correctly

    ebc671b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    clusterIssues and PRs related to the cluster subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions