Skip to content

meta: 2 identical files in the same folder #12624

Closed
Closed
meta: 2 identical files in the same folder#12624
Labels
metaIssues and PRs related to the general management of the project.npmIssues and PRs related to the npm client dependency or the npm registry.windowsIssues and PRs related to the Windows platform.

Description

@vsemozhetbyt
vsemozhetbyt
opened on Apr 24, 2017

In deps/npm/node_modules/request/node_modules/form-data/ there are 2 identical files: Readme.md and README.md. This confuses archivators on Windows: each time they try to unpack a repo from a GH zip, they stop and ask if the file should be rewritten. I am not sure what we can do about this issue.

Activity

  1. vsemozhetbyt
    added
    metaIssues and PRs related to the general management of the project.
    windowsIssues and PRs related to the Windows platform.
    on Apr 24, 2017

  2. Fishrock123 commented on Apr 24, 2017

    @Fishrock123
    Fishrock123
    on Apr 24, 2017
    Contributor

    There should only be one...

  3. gibfahn commented on Apr 24, 2017

    @gibfahn
    gibfahn
    on Apr 24, 2017
    Member

    I see that form-data has a Readme.md rather than a README.md, maybe something is capitalising it at some point?

  4. gibfahn
    added
    npmIssues and PRs related to the npm client dependency or the npm registry.
    on Apr 24, 2017

  5. vsemozhetbyt commented on Apr 24, 2017

    @vsemozhetbyt
    vsemozhetbyt
    on Apr 24, 2017
    ContributorAuthor

    npm has README.md: https://github.com/npm/npm/tree/latest/node_modules/request/node_modules/form-data

  6. Fishrock123 commented on Apr 24, 2017

    @Fishrock123
    Fishrock123
    on Apr 24, 2017
    Contributor

    I think it used to be README.md... so maybe git didn't rename it properly for case-insensitive filesystems?

    cc @zkat but I think we can just remove the old README.md.

    refs: #11085 & #11020...

  7. zkat commented on Apr 24, 2017

    @zkat
    zkat
    on Apr 24, 2017
    Contributor

    oh god just remove one please this has been a nightmare

  8. vsemozhetbyt commented on Apr 24, 2017

    @vsemozhetbyt
    vsemozhetbyt
    on Apr 24, 2017
    ContributorAuthor

    So which of them should be removed?

  9. zkat commented on Apr 24, 2017

    @zkat
    zkat
    on Apr 24, 2017
    Contributor

    @vsemozhetbyt README.md is the one that was (un?)intentionally capitalized

  10. vsemozhetbyt commented on Apr 24, 2017

    @vsemozhetbyt
    vsemozhetbyt
    on Apr 24, 2017
    ContributorAuthor

    I can't actually remove it as I am on Windows so I can already have only one locally) Can anybody remove it from a proper OS?

  11. Fishrock123 commented on Apr 25, 2017

    @Fishrock123
    Fishrock123
    on Apr 25, 2017
    Contributor

    Yeah I'll get around to it today, hopefully.

  12. Fishrock123 commented on Apr 25, 2017

    @Fishrock123
    Fishrock123
    on Apr 25, 2017
    Contributor

    Ok uh, I can't seem to do it now, maybe after landing v4.5.0... @nodejs/ctc can someone with a case insensitive FS and git fix this?

  13. Fishrock123 commented on Apr 25, 2017

    @Fishrock123
    Fishrock123
    on Apr 25, 2017
    Contributor

    Maybe I can do it from the GitHub GUI.... https://github.com/form-data/form-data has Readme.md.

  14. Fishrock123
    added a commit that references this issue on Apr 25, 2017

    deps: remove form-data/README.md

    5bd9c45

  15. Fishrock123 commented on Apr 25, 2017

    @Fishrock123
    Fishrock123
    on Apr 25, 2017
    Contributor

    Ok, looks like it worked from the GitHub GUI: #12643

  16. refack commented on Apr 26, 2017

    @refack
    refack
    on Apr 26, 2017
    Contributor

    Highlander - "There Can Be Only One"

  17. Fishrock123 commented on Apr 26, 2017

    @Fishrock123
    Fishrock123
    on Apr 26, 2017
    Contributor

    Fixed in e8f3163

  18. Fishrock123
    closed this as completedon Apr 26, 2017

  19. vsemozhetbyt commented on Apr 26, 2017

    @vsemozhetbyt
    vsemozhetbyt
    on Apr 26, 2017
    ContributorAuthor

    Refs: #12680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    metaIssues and PRs related to the general management of the project.npmIssues and PRs related to the npm client dependency or the npm registry.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions