Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test parallel/test-setproctitle.js fails on alpine #12399

Closed
tanuck opened this issue Apr 13, 2017 · 2 comments
Closed

Test parallel/test-setproctitle.js fails on alpine #12399

tanuck opened this issue Apr 13, 2017 · 2 comments
Labels
good first issue Issues that are suitable for first-time contributors. process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.

Comments

@tanuck
Copy link

tanuck commented Apr 13, 2017

  • Version: 7.9.0
  • Platform: Linux f3f027fe364c 4.4.41-boot2docker #1 SMP Wed Jan 11 03:05:24 UTC 2017 x86_64 Linux
  • Subsystem: process, tests

I've been trying to get the full testsuite to run while building a docker image based on FROM alpine:latest. The parallel/test-setproctitle.js seems to be the only failing test. Thats due to BusyBox ps doesn't support the -p switch. Installing procps package before compiling/testing solves this but could the test instead be refactored to remove this dependency? Using either /proc/[pid]/comm or /proc/[pid]/stat directly instead?

Cheers
@vsemozhetbyt vsemozhetbyt added process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests. labels Apr 13, 2017
@bnoordhuis
Copy link
Member

Pull request welcome, I'd say. However:

Using either /proc/[pid]/comm or /proc/[pid]/stat directly instead?

That won't fly, it's Linux-only.

@bnoordhuis bnoordhuis added the good first issue Issues that are suitable for first-time contributors. label Apr 13, 2017
@DavidCai1111 DavidCai1111 mentioned this issue Apr 14, 2017
Closed
3 tasks
@DavidCai1111
Copy link
Member

@tanuck I think this issue should have been solved by #12413 😃

evanlucas pushed a commit that referenced this issue Apr 25, 2017
@DavidCai1111 @evanlucas
test: fix parallel/test-setproctitle.js on alpine
60baea2 
Since Busybox ps does not support -p switch, using ps -o and grep
instead to get the process title and then check it.

PR-URL: #12413
Fixes: #12399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
evanlucas pushed a commit that referenced this issue May 1, 2017
@DavidCai1111 @evanlucas
test: fix parallel/test-setproctitle.js on alpine
0a1379e 
Since Busybox ps does not support -p switch, using ps -o and grep
instead to get the process title and then check it.

PR-URL: #12413
Fixes: #12399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
evanlucas pushed a commit that referenced this issue May 2, 2017
@DavidCai1111 @evanlucas
test: fix parallel/test-setproctitle.js on alpine
96b2faa 
Since Busybox ps does not support -p switch, using ps -o and grep
instead to get the process title and then check it.

PR-URL: #12413
Fixes: #12399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@DavidCai1111 DavidCai1111 mentioned this issue May 17, 2017
Closed
3 tasks
DavidCai1111 added a commit to DavidCai1111/node that referenced this issue Jun 19, 2017
@DavidCai1111
test: fix parallel/test-setproctitle.js on alpine
d0210c3 
Since Busybox ps does not support -p switch, using ps -o and grep
instead to get the process title and then check it.

PR-URL: nodejs#12413
Fixes: nodejs#12399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this issue Jul 10, 2017
@DavidCai1111 @MylesBorins
test: fix parallel/test-setproctitle.js on alpine
bff589b 
Since Busybox ps does not support -p switch, using ps -o and grep
instead to get the process title and then check it.

Backport-PR-URL: #13072
PR-URL: #12413
Fixes: #12399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this issue Jul 11, 2017
@DavidCai1111 @MylesBorins
test: fix parallel/test-setproctitle.js on alpine
c902265 
Since Busybox ps does not support -p switch, using ps -o and grep
instead to get the process title and then check it.

Backport-PR-URL: #13072
PR-URL: #12413
Fixes: #12399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix parallel/test-setproctitle.js on alpine DavidCai1111/node
4 participants
@bnoordhuis @tanuck @DavidCai1111 @vsemozhetbyt