Skip to content

Fix flaky sequential/test-domain-abort-on-uncaught and move back to parallel #11826

Closed
Closed
Fix flaky sequential/test-domain-abort-on-uncaught and move back to parallel#11826
Labels
armIssues and PRs related to the ARM architecture.domainIssues and PRs related to the domain subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@gibfahn
gibfahn
opened on Mar 13, 2017
  • Version: master
  • Platform: arm
  • Subsystem: test

See #11814 (comment)

This test is flaky under load. This can be seen by running it with a command like this:

tools/test.py -j 32 --repeat=32 test/parallel/test-domain-abort-on-uncaught.js

(If 32 isn't enough to cause problems on your setup, try 64 or higher.)

There are at least three solutions possible here:

  • move the test to sequential Done in test: fix flaky test-domain-abort-on-uncaught #11817
  • break the test up into as many as 13 separate test files so that each one is launching one additional node process rather than one test launching 13 of them in parallel
  • rewrite the test to run the 13 processes sequentially rather than in parallel

The second or third option above can be a good first contribution for someone.

How to fix

  • Read through the linked issue and understand the problem.
  • Replicate the failure on your machine.
  • Fix the test (probably using one of the methods suggested above).
  • Move the test back to test/parallel/ (it's currently in test/sequential/).
  • Follow CONTRIBUTING.md and submit a PR with the fix.

If you want to have a go at this comment on this issue to let us know. If you have any questions ask them here.

Activity

  1. gibfahn
    added
    armIssues and PRs related to the ARM architecture.
    domainIssues and PRs related to the domain subsystem.
    good first issueIssues that are suitable for first-time contributors.
    on Mar 13, 2017
  2. mscdex
    added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Mar 13, 2017

  3. clarenced commented on Mar 13, 2017

    @clarenced
    clarenced
    on Mar 13, 2017
    Contributor

    Hi @gibfahn I would like to fix this issue, I have already done a PR. But it seems the file test-domain-abort-on-uncaught.js is still in test/parallel. Can you confirm that?

  4. gibfahn commented on Mar 14, 2017

    @gibfahn
    gibfahn
    on Mar 14, 2017
    MemberAuthor

    @clarenced yes, #11817 hasn't landed yet (and probably shouldn't if you've already raised a PR). So you can fix the test and leave it in parallel.

    EDIT: Let me know the number when you raise it.

    cc/ @Trott

  5. Trott commented on Mar 14, 2017

    @Trott
    Trott
    on Mar 14, 2017
    Member

    I plan on landing #11817 in another 18 hours or so.

  6. gibfahn commented on Mar 17, 2017

    @gibfahn
    gibfahn
    on Mar 17, 2017
    MemberAuthor

    @clarenced #11817 has landed, which will mean that your branch will need to be rebased on master.

  7. clarenced commented on Mar 18, 2017

    @clarenced
    clarenced
    on Mar 18, 2017
    Contributor

    Hi @gibfahn and @Trott, I created a pull request for this issue #11920

  8. Trott
    added a commit that references this issue on Jul 30, 2017

    test: refactor test-domain-abort-on-uncaught

    8f0f403

  9. Trott commented on Jul 30, 2017

    @Trott
    Trott
    on Jul 30, 2017
    Member

    Proposed fix in #14541

  10. Trott
    removed
    good first issueIssues that are suitable for first-time contributors.
    on Jul 30, 2017
  11. Trott
    added a commit that references this issue on Aug 2, 2017

    test: refactor test-domain-abort-on-uncaught

    548cc72
  12. Trott
    closed this as completedin 548cc72on Aug 2, 2017
  13. addaleax
    added a commit that references this issue on Aug 7, 2017

    test: refactor test-domain-abort-on-uncaught

    5094f2c
  14. MylesBorins
    added 3 commits that reference this issue on Aug 16, 2017

    test: refactor test-domain-abort-on-uncaught

    9c59f1c

    test: refactor test-domain-abort-on-uncaught

    014a9bd
  15. MylesBorins
    added 2 commits that reference this issue on Sep 3, 2017

    test: refactor test-domain-abort-on-uncaught

    f0b3bf3

    test: refactor test-domain-abort-on-uncaught

    2ce80d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    armIssues and PRs related to the ARM architecture.domainIssues and PRs related to the domain subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions