Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: typo in comment #11491

Closed
mscdex opened this issue Feb 22, 2017 · 6 comments
Closed

process: typo in comment #11491

mscdex opened this issue Feb 22, 2017 · 6 comments
Labels
process Issues and PRs related to the process subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Feb 22, 2017 •
edited
Loading

  • Version: master
  • Platform: n/a
  • Subsystem: process

lib/internal/process.js contains a typo ("renamining" should be "remaining").
@mscdex mscdex added good first issue Issues that are suitable for first-time contributors. process Issues and PRs related to the process subsystem. labels Feb 22, 2017
@mscdex mscdex changed the title Typo in comment process: typo in comment Feb 22, 2017
@lastmasta
Copy link

I'd love to address this issue! How can I submit a PR for this?

@mscdex
Copy link
Contributor Author

mscdex commented Feb 22, 2017 •
edited
Loading

@lastmasta You might start with the contributing guide which has a step-by-step process on how to submit a PR to the node repository.

@levsthings levsthings mentioned this issue Feb 22, 2017
Closed
1 task
@lastmasta
Copy link

@mscdex Thank you, I already read it. But I get this error when I try to push the changes:

remote: Permission to nodejs/node.git denied to lastmasta. fatal: unable to access 'https://github.com/nodejs/node.git/': The requested URL returned error: 403

@levsthings
Copy link
Contributor

@lastmasta Apparently we were on the same issue right at the same minute, just pushed a PR on this because no updates were made after you mentioned it 10h ago.

@lastmasta
Copy link

@levsthings That's great! I'll address another 'good first contribution' issue then.

@evanlucas evanlucas removed the good first issue Issues that are suitable for first-time contributors. label Feb 23, 2017
@evanlucas
Copy link
Contributor

I removed the good first contribution label since there is a PR up for this now. Thanks!

italoacasas pushed a commit to italoacasas/node that referenced this issue Feb 27, 2017
@levsthings @italoacasas
process: fix typo in comments
fe7a722 
Fixing a typo in comments, the word 'remaining' had a typo.

PR-URL: nodejs#11503
Fixes: nodejs#11491
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell pushed a commit that referenced this issue Mar 7, 2017
@levsthings @jasnell
process: fix typo in comments
a95851e 
Fixing a typo in comments, the word 'remaining' had a typo.

PR-URL: #11503
Fixes: #11491
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this issue Mar 9, 2017
@levsthings @MylesBorins
process: fix typo in comments
02e5f5c 
Fixing a typo in comments, the word 'remaining' had a typo.

PR-URL: #11503
Fixes: #11491
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @evanlucas @lastmasta @levsthings