tls documentation says that checkServerIdentity function should throw an error. It should not.

[lockhart-raphael]

• Version: 6.7.0 - 7.5.0 (at least)
• Platform: All? tested on MacOS / Linux
• Subsystem: TLS

The documentation for the checkServerIdentity function at https://nodejs.org/api/tls.html#tls_tls_connect_options_callback
states that the provided function "should throw an error if verification fails. "

However, the implementation (https://github.com/nodejs/node/blob/master/lib/_tls_wrap.js#L1083) expects a truthy value returned from the function as the error, and has no try / catch logic to catch an error if thrown, with the result that if the checkServerIdentity function throws an error the whole process will likely exit. Either the docs or the implementation should be corrected to reflect the intended behavior.

[sam-github]

fixed in #10846, but no one spoke up for it

I'll try to factor pieces of those docs out and get them accepted

[Trott]

@sam-github Should this remain open?

[sam-github]

yes, the docs are wrong

[apapirovski]

Fixed by #17203