Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-tls-session-cache failure on smtartos16 - v7.x #11003

Closed
mhdawson opened this issue Jan 25, 2017 · 5 comments
Closed

test-tls-session-cache failure on smtartos16 - v7.x #11003

mhdawson opened this issue Jan 25, 2017 · 5 comments
Labels
smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Comments

@mhdawson
Copy link
Member

mhdawson commented Jan 25, 2017

  • Version: v7.x
  • Platform: smartos 16
  • Subsystem: tls

https://ci.nodejs.org/job/node-test-commit-smartos-mdawson/nodes=smartos16-64/7/console

not ok 1261 parallel/test-tls-session-cache
  ---
  duration_ms: 60.83
  severity: fail
  stack: |-
    timeout
  ...

Failed in test run for unrelated changes, so likely intermittent.

@mscdex mscdex added smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem. labels Jan 25, 2017
@misterdjules
Copy link

misterdjules commented Jan 28, 2017

As I mentioned in #11026 (comment), I'll take a look at these failures early next week.

@misterdjules
Copy link

Looking at it now.

@misterdjules
Copy link

To paraphrase what I wrote in #11026:

So far, I haven't been able to reproduce the problem described by any of the issues listed above.

In order to be able to get more information and investigate future spurious failures, I submitted a PR that sends SIGABRT instead of SIGTERM to test processes that timeout. This will allow us to take a look at core files generated from these processes with tools such as llnode and mdb_v8, and will potentially help us root cause these issues.

In the meantime I'll continue trying to reproduce and investigate those issues, I'll keep you posted.

@misterdjules
Copy link

Again, pasting what I wrote in #11026 to make sure anyone coming here is aware of the current progress on this issue.

#11086 was merged and nodejs/build#613 was created to make tests that time out generate a core file that could be inspected to help root cause these failures.

Thus, I'd suggest that we mark this test (and the other flaky ones mentioned in #11026 (comment)) as flaky on SmartOS.

Then we should make sure that when a build is marked "unstable" on SmartOS, we grab the core files that are generated and upload them somewhere (we can use Joyent's manta for that, as this is part of the resources donated by Joyent to the project) where they won't be cleaned up for further investigation.

How does that sound?

@Trott
Copy link
Member

Trott commented Jul 16, 2017

Haven't seen this in months. Going to close, but feel free to re-open or comment if it's still something that happens.

@Trott Trott closed this as completed Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants