Skip to content

fs.write doesn't coerce data value to a string #1098

Closed
@xibre

Description

@xibre

Hi. Today I tried to run something similar to this:

var data = true;
fs.write(fd, data, cb);

data value must be coerced to string as mentioned in API.
But that failed with message:

Assertion failed: val->IsString() == true, file src\string_bytes.cc, line 286

fs.writeSync, however worked well.

Then I found this:
https://github.com/iReal/io.js/blob/v1.x/lib/fs.js#L632-L633

There should be !==, not ===.

Metadata

Metadata

Assignees

No one assigned

    Labels

    fsIssues and PRs related to the fs subsystem / file system.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions