Repository navigation
Prevent EMFILE #10432
Description
Try to run (with empty file.txt in working dir):
for(let i = 0; i < 10e3; i++) { require('fs').watch('file.txt') }Produces instantly: Uncaught Error: watch file.txt EMFILE
It make sense to dedupe multiple watchers on same file to prevent 'too many files open'?
- Version: v7.2.1
- Platform: macOS
Activity
fhalde commentedon Dec 24, 2016
I feel one can always make a wrapper over the
fs.watchto do the deduplication.nodedoing that will restrict/hinder the API users from having multiple watchers for different purposes.One way to say
nodeto do deduplication yet keeping the API flexible is by adding some newoptionsam-github commentedon Dec 25, 2016
This is not so different from a file open, it uses a fd, and I can't see why you would want to open 1000 watches on the same file.
bnoordhuis commentedon Jan 10, 2017
Seems the consensus is that node core isn't the place to fix this. I'll go ahead and close the issue.