Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1b2a96612567bd6153ff435d46f64775480bc829
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 82ac335bdd8dd0379a53ad5e18d26b87f6d1b748
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Jan 29, 2025

  1. test: convert test_encoding_binding.cc to a JS test 

    The cctest file `test_encoding_binding.cc` is never tested and it is
not a valid test. Binding functions should never be tested with V8 API
circumvented. A binding function should only be tested with JS calls.

PR-URL: #56791
Refs: #55275
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @legendecas @nodejs-github-bot
    legendecas authored and nodejs-github-bot committed Jan 29, 2025
    Configuration menu
    Copy the full SHA
    3c105b6 View commit details
    Browse the repository at this point in the history

  2. test: search cctest files 

    To prevent a new cctest missing from the `node.gyp`, search cctest
files with tool `search_files.py` at configure time.

PR-URL: #56791
Refs: #55275
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @legendecas @nodejs-github-bot
    legendecas authored and nodejs-github-bot committed Jan 29, 2025
    Configuration menu
    Copy the full SHA
    82ac335 View commit details
    Browse the repository at this point in the history
Loading