Skip to content

Commit f8e93e8

Browse files
vsemozhetbytMylesBorins
authored andcommitted
doc: fix links in some intra-repository docs
PR-URL: #15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 5f469a2 commit f8e93e8

File tree

3 files changed

+14
-13
lines changed

3 files changed

+14
-13
lines changed

COLLABORATOR_GUIDE.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
- [Internal vs. Public API](#internal-vs-public-api)
99
- [Breaking Changes](#breaking-changes)
1010
- [Deprecations](#deprecations)
11-
- [Involving the TSC](#involving-the-TSC)
11+
- [Involving the TSC](#involving-the-tsc)
1212
* [Landing Pull Requests](#landing-pull-requests)
1313
- [Technical HOWTO](#technical-howto)
1414
- [I Just Made a Mistake](#i-just-made-a-mistake)
@@ -367,7 +367,7 @@ The TSC should serve as the final arbiter where required.
367367

368368
## Landing Pull Requests
369369

370-
* Please never use GitHub's green ["Merge Pull Request"](https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-using-the-github-web-interface) button.
370+
* Please never use GitHub's green ["Merge Pull Request"](https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-on-github) button.
371371
* If you do, please force-push removing the merge.
372372
* Reasons for not using the web interface button:
373373
* The merge method will add an unnecessary merge commit.
@@ -394,8 +394,8 @@ information regarding the change process:
394394
- Useful for @mentions / contact list if something goes wrong in the PR.
395395
- Protects against the assumption that GitHub will be around forever.
396396

397-
Review the commit message to ensure that it adheres to the guidelines
398-
outlined in the [contributing](./CONTRIBUTING.md#step-3-commit) guide.
397+
Review the commit message to ensure that it adheres to the guidelines outlined
398+
in the [contributing](./CONTRIBUTING.md#commit-message-guidelines) guide.
399399

400400
See the commit log for examples such as
401401
[this one](https://github.com/nodejs/node/commit/b636ba8186) if unsure
@@ -520,7 +520,7 @@ commit message for that commit. This is a good moment to fix incorrect
520520
commit logs, ensure that they are properly formatted, and add
521521
`Reviewed-By` lines.
522522
* The commit message text must conform to the
523-
[commit message guidelines](./CONTRIBUTING.md#step-3-commit).
523+
[commit message guidelines](./CONTRIBUTING.md#commit-message-guidelines).
524524

525525
Run tests (`make -j4 test` or `vcbuild test`). Even though there was a
526526
successful continuous integration run, other changes may have landed on master
@@ -594,7 +594,8 @@ commit final.
594594
Long Term Support (often referred to as *LTS*) guarantees application developers
595595
a 30 month support cycle with specific versions of Node.js.
596596

597-
You can find more information [in the full LTS plan](https://github.com/nodejs/lts#lts-plan).
597+
You can find more information
598+
[in the full release plan](https://github.com/nodejs/Release#release-plan).
598599

599600
#### How does LTS work?
600601

@@ -674,5 +675,5 @@ release. This process of making a release will be a collaboration between the
674675
LTS working group and the Release team.
675676

676677
[backporting guide]: doc/guides/backporting-to-release-lines.md
677-
[Stability Index]: https://github.com/nodejs/node/pull/doc/api/documentation.md#stability-index
678+
[Stability Index]: doc/api/documentation.md#stability-index
678679
[Enhancement Proposal]: https://github.com/nodejs/node-eps

doc/guides/backporting-to-release-lines.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Each release line has a staging branch that the releaser will use as a scratch
66
pad while preparing a release. The branch name is formatted as follows:
77
`vN.x-staging` where `N` is the major release number.
88

9-
*Note*: For the active staging branches see the [LTS Schedule][].
9+
*Note*: For the active staging branches see the [Release Schedule][].
1010

1111
## What needs to be backported?
1212

@@ -19,7 +19,7 @@ requesting that a backport pull request be made.
1919
## What can be backported?
2020

2121
The "Current" release line is much more lenient than the LTS release lines in
22-
what can be landed. Our LTS release lines (see the [LTS Plan][])
22+
what can be landed. Our LTS release lines (see the [Release Plan][])
2323
require that commits mature in the Current release for at least 2 weeks before
2424
they can be landed in an LTS staging branch. Only after "maturation" will those
2525
commits be cherry-picked or backported.
@@ -81,6 +81,6 @@ hint: and commit the result with 'git commit'
8181
After the PR lands replace the `backport-requested-v6.x` label on the original
8282
PR with `backported-to-v6.x`.
8383

84-
[LTS Schedule]: https://github.com/nodejs/LTS/#lts-schedule1
85-
[LTS Plan]: https://github.com/nodejs/LTS#lts-plan
84+
[Release Schedule]: https://github.com/nodejs/Release#release-schedule1
85+
[Release Plan]: https://github.com/nodejs/Release#release-plan
8686
[`node-test-pull-request`]: https://ci.nodejs.org/job/node-test-pull-request/build

doc/releases.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ If you didn't wait for ARM builds in the previous step before promoting the rele
291291

292292
### 13. Check the Release
293293

294-
Your release should be available at <https://nodejs.org/dist/vx.y.z/> and <https://nodejs.org/dist/latest/>. Check that the appropriate files are in place. You may want to check that the binaries are working as appropriate and have the right internal version strings. Check that the API docs are available at <https://nodejs.org/api/>. Check that the release catalog files are correct at <https://nodejs.org/dist/index.tab> and <https://nodejs.org/dist/index.json>.
294+
Your release should be available at `https://nodejs.org/dist/vx.y.z/` and <https://nodejs.org/dist/latest/>. Check that the appropriate files are in place. You may want to check that the binaries are working as appropriate and have the right internal version strings. Check that the API docs are available at <https://nodejs.org/api/>. Check that the release catalog files are correct at <https://nodejs.org/dist/index.tab> and <https://nodejs.org/dist/index.json>.
295295

296296
### 14. Create a Blog Post
297297

@@ -312,7 +312,7 @@ Refs: <full URL to your release proposal PR>
312312

313313
### 15. Announce
314314

315-
The nodejs.org website will automatically rebuild and include the new version. To announce the build on Twitter through the official @nodejs account, email [pr@nodejs.org](pr@nodejs.org) with a message such as:
315+
The nodejs.org website will automatically rebuild and include the new version. To announce the build on Twitter through the official @nodejs account, email [pr@nodejs.org](mailto:pr@nodejs.org) with a message such as:
316316

317317
> v5.8.0 of @nodejs is out: https://nodejs.org/en/blog/release/v5.8.0/ … something here about notable changes
318318

0 commit comments

Comments
 (0)