doc: fix links in some intra-repository docs #15675
Conversation
|
I do not know how to fix this link in the doc/releases.md#3-a-publicly-listed-gpg-key: https://sks-keyservers.net/i/#submit (404 Not Found) Let me know about the equivalent. |
COLLABORATOR_GUIDE.md
Outdated
| @@ -395,7 +395,7 @@ information regarding the change process: | |||
| - Protects against the assumption that GitHub will be around forever. | |||
|
|
|||
| Review the commit message to ensure that it adheres to the guidelines | |||
| outlined in the [contributing](./CONTRIBUTING.md#step-3-commit) guide. | |||
| outlined in the [contributing](./CONTRIBUTING.md#step-4-commit) guide. | |||
There was a problem hiding this comment.
Maybe it's better to use CONTRIBUTING.md#commit-message-guidelines.
COLLABORATOR_GUIDE.md
Outdated
| @@ -520,7 +520,7 @@ commit message for that commit. This is a good moment to fix incorrect | |||
| commit logs, ensure that they are properly formatted, and add | |||
| `Reviewed-By` lines. | |||
| * The commit message text must conform to the | |||
| [commit message guidelines](./CONTRIBUTING.md#step-3-commit). | |||
| [commit message guidelines](./CONTRIBUTING.md#step-4-commit). | |||
|
Thank you, Let's see what others think. The https://sks-keyservers.net/ itself is OK, it just https://sks-keyservers.net/i/#submit (some form?) is now 404. |
|
How http://hkps.pool.sks-keyservers.net looks is different for everybody because it's just a mirror to a pool of key servers. For me personally, just two minutes ago that URL showed "keyserver.ntzwrk.org" but now it shows "keys2.kfwebs.net". Because of that, the submission feature may not always be available on the mirror the URL currently redirects to; the anchor for the "Submit" section may certainly be different as well. I would just pick one keyserver, like the one provided by MIT or by Ubuntu/Canonical. They end up getting synced pretty soon anyway. |
|
Rebased after 9807744 |
|
@TimothyGu Can you suggest a wording with one of your links (or both)? |
PR-URL: #15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Went ahead and landed in 6be96c7. We can make further changes in a separate PR |
PR-URL: #15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: nodejs/node#15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #15675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Checklist
Affected core subsystem(s)
doc, meta