Skip to content

Commit

Permalink
child_process: remove unreachable code
Browse files Browse the repository at this point in the history
_convertCustomFds() is only called from normalizeSpawnArguments(),
which always provides an options object. Therefore, there is no
need to check for options in _convertCustomFds().

PR-URL: #9307
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
cjihrig committed Oct 29, 2016
1 parent d0ed173 commit ec7c27f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/child_process.js
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ var _deprecatedCustomFds = internalUtil.deprecate(function(options) {
'Use options.stdio instead.');

function _convertCustomFds(options) {
if (options && options.customFds && !options.stdio) {
if (options.customFds && !options.stdio) {
_deprecatedCustomFds(options);
}
}
Expand Down

0 comments on commit ec7c27f

Please sign in to comment.