Skip to content

Commit

Permalink
test: improve the code in test-fs-read-stream
Browse files Browse the repository at this point in the history
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: #10556
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
  • Loading branch information
edsadr authored and italoacasas committed Jan 30, 2017
1 parent eba9add commit dba8d20
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions test/parallel/test-fs-read-stream-fd.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,20 @@ const common = require('../common');
const fs = require('fs');
const assert = require('assert');
const path = require('path');
var file = path.join(common.tmpDir, '/read_stream_fd_test.txt');
var input = 'hello world';
var output = '';
var fd, stream;
const file = path.join(common.tmpDir, '/read_stream_fd_test.txt');
const input = 'hello world';

let output = '';
common.refreshTmpDir();
fs.writeFileSync(file, input);
fd = fs.openSync(file, 'r');

stream = fs.createReadStream(null, { fd: fd, encoding: 'utf8' });
stream.on('data', function(data) {
const fd = fs.openSync(file, 'r');
const stream = fs.createReadStream(null, { fd: fd, encoding: 'utf8' });

stream.on('data', (data) => {
output += data;
});

process.on('exit', function() {
fs.unlinkSync(file);
assert.equal(output, input);
process.on('exit', () => {
assert.strictEqual(output, input);
});

0 comments on commit dba8d20

Please sign in to comment.