Skip to content

Commit c4833ff

Browse files
tniessenjuanarbol
authored andcommitted
src: remove SecureContext::operator*
This rather mysterious operator is only used once and can easily be replaced with ssl_ctx(). PR-URL: #43121 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
1 parent 745d9a2 commit c4833ff

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

src/crypto/crypto_common.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ const char* GetServerName(SSL* ssl) {
209209
}
210210

211211
bool SetGroups(SecureContext* sc, const char* groups) {
212-
return SSL_CTX_set1_groups_list(**sc, groups) == 1;
212+
return SSL_CTX_set1_groups_list(sc->ssl_ctx(), groups) == 1;
213213
}
214214

215215
const char* X509ErrorCode(long err) { // NOLINT(runtime/int)

src/crypto/crypto_context.h

-2
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ class SecureContext final : public BaseObject {
4141
static void RegisterExternalReferences(ExternalReferenceRegistry* registry);
4242
static SecureContext* Create(Environment* env);
4343

44-
SSL_CTX* operator*() const { return ctx_.get(); }
45-
4644
SSL_CTX* ssl_ctx() const { return ctx_.get(); }
4745

4846
SSLPointer CreateSSL();

0 commit comments

Comments
 (0)