Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove SecureContext::operator* #43121

Conversation

tniessen
Copy link
Member

This rather mysterious operator is only used once and can easily be replaced with ssl_ctx().

This rather mysterious operator is only used once and can easily be
replaced with ssl_ctx().
@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label May 16, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels May 16, 2022
@tniessen tniessen added commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 16, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 16, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 17, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 17, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43121
✔  Done loading data for nodejs/node/pull/43121
----------------------------------- PR info ------------------------------------
Title      src: remove SecureContext::operator* (#43121)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     tniessen:src-crypto-remove-securecontext-operatorast -> nodejs:master
Labels     crypto, c++, fast-track, author ready, needs-ci
Commits    1
 - src: remove SecureContext::operator*
Committers 1
 - Tobias Nießen 
PR-URL: https://github.com/nodejs/node/pull/43121
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43121
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 16 May 2022 20:39:16 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43121#pullrequestreview-975353507
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/43121#pullrequestreview-975409202
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-05-17T04:03:53Z: https://ci.nodejs.org/job/node-test-pull-request/44041/
- Querying data for job/node-test-pull-request/44041/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2338846785

@tniessen tniessen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 17, 2022
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 17, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 17, 2022
@nodejs-github-bot nodejs-github-bot merged commit ace89d9 into nodejs:master May 17, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in ace89d9

bengl pushed a commit that referenced this pull request May 30, 2022
This rather mysterious operator is only used once and can easily be
replaced with ssl_ctx().

PR-URL: #43121
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@bengl bengl mentioned this pull request May 31, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
This rather mysterious operator is only used once and can easily be
replaced with ssl_ctx().

PR-URL: #43121
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
This rather mysterious operator is only used once and can easily be
replaced with ssl_ctx().

PR-URL: #43121
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
This rather mysterious operator is only used once and can easily be
replaced with ssl_ctx().

PR-URL: #43121
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
This rather mysterious operator is only used once and can easily be
replaced with ssl_ctx().

PR-URL: #43121
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
This rather mysterious operator is only used once and can easily be
replaced with ssl_ctx().

PR-URL: nodejs/node#43121
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants