Skip to content

Commit

Permalink
test: address nits and rename the corresponding fixture
Browse files Browse the repository at this point in the history
Refs: #19105

PR-URL: #19161
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
  • Loading branch information
ryzokuken authored and MylesBorins committed Mar 20, 2018
1 parent 22484e1 commit c0c6d58
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
File renamed without changes.
2 changes: 1 addition & 1 deletion test/sequential/test-fs-stat-sync-overflow.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const assert = require('assert');
const { exec } = require('child_process');

const cmd =
`"${process.execPath}" "${fixturesDir}/test-regress-GH-4015.js"`;
`"${process.execPath}" "${fixturesDir}/test-fs-stat-sync-overflow.js"`;

exec(cmd, function(err, stdout, stderr) {
assert(/RangeError: Maximum call stack size exceeded/.test(stderr));
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-net-response-size.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
const common = require('../common');

// Make sure the net module's server doesn't throw an error when handling
// responses that are either too long or too small (especially on windows)
// responses that are either too long or too small (especially on Windows)
// https://github.com/nodejs/node-v0.x-archive/issues/1697

const net = require('net');
Expand Down

0 comments on commit c0c6d58

Please sign in to comment.