You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: COLLABORATOR_GUIDE.md
+8-7Lines changed: 8 additions & 7 deletions
Original file line number
Diff line number
Diff line change
@@ -8,7 +8,7 @@
8
8
-[Internal vs. Public API](#internal-vs-public-api)
9
9
-[Breaking Changes](#breaking-changes)
10
10
-[Deprecations](#deprecations)
11
-
-[Involving the TSC](#involving-the-TSC)
11
+
-[Involving the TSC](#involving-the-tsc)
12
12
*[Landing Pull Requests](#landing-pull-requests)
13
13
-[Technical HOWTO](#technical-howto)
14
14
-[I Just Made a Mistake](#i-just-made-a-mistake)
@@ -361,7 +361,7 @@ The TSC should serve as the final arbiter where required.
361
361
362
362
## Landing Pull Requests
363
363
364
-
* Please never use GitHub's green ["Merge Pull Request"](https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-using-the-github-web-interface) button.
364
+
* Please never use GitHub's green ["Merge Pull Request"](https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-on-github) button.
365
365
* If you do, please force-push removing the merge.
366
366
* Reasons for not using the web interface button:
367
367
* The merge method will add an unnecessary merge commit.
@@ -388,8 +388,8 @@ information regarding the change process:
388
388
- Useful for @mentions / contact list if something goes wrong in the PR.
389
389
- Protects against the assumption that GitHub will be around forever.
390
390
391
-
Review the commit message to ensure that it adheres to the guidelines
392
-
outlined in the [contributing](./CONTRIBUTING.md#step-3-commit) guide.
391
+
Review the commit message to ensure that it adheres to the guidelines outlined
392
+
in the [contributing](./CONTRIBUTING.md#commit-message-guidelines) guide.
393
393
394
394
See the commit log for examples such as
395
395
[this one](https://github.com/nodejs/node/commit/b636ba8186) if unsure
@@ -514,7 +514,7 @@ commit message for that commit. This is a good moment to fix incorrect
514
514
commit logs, ensure that they are properly formatted, and add
Copy file name to clipboardExpand all lines: doc/releases.md
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -283,7 +283,7 @@ Note: it is possible to only sign a release by running `./tools/release.sh -s vX
283
283
284
284
### 13. Check the Release
285
285
286
-
Your release should be available at <https://nodejs.org/dist/vx.y.z/> and <https://nodejs.org/dist/latest/>. Check that the appropriate files are in place. You may want to check that the binaries are working as appropriate and have the right internal version strings. Check that the API docs are available at <https://nodejs.org/api/>. Check that the release catalog files are correct at <https://nodejs.org/dist/index.tab> and <https://nodejs.org/dist/index.json>.
286
+
Your release should be available at `https://nodejs.org/dist/vx.y.z/` and <https://nodejs.org/dist/latest/>. Check that the appropriate files are in place. You may want to check that the binaries are working as appropriate and have the right internal version strings. Check that the API docs are available at <https://nodejs.org/api/>. Check that the release catalog files are correct at <https://nodejs.org/dist/index.tab> and <https://nodejs.org/dist/index.json>.
287
287
288
288
### 14. Create a Blog Post
289
289
@@ -304,7 +304,7 @@ Refs: <full URL to your release proposal PR>
304
304
305
305
### 15. Announce
306
306
307
-
The nodejs.org website will automatically rebuild and include the new version. To announce the build on Twitter through the official @nodejs account, email [pr@nodejs.org](pr@nodejs.org) with a message such as:
307
+
The nodejs.org website will automatically rebuild and include the new version. To announce the build on Twitter through the official @nodejs account, email [pr@nodejs.org](mailto:pr@nodejs.org) with a message such as:
308
308
309
309
> v5.8.0 of @nodejs is out: https://nodejs.org/en/blog/release/v5.8.0/ … something here about notable changes
0 commit comments