Change noCompletion to showCompletion

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
nodejs · Feb 28, 2023 · 7eef4d7 · 7eef4d7
1 parent d636ce8
commit 7eef4d7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/internal/repl/utils.js b/lib/internal/repl/utils.js
@@ -365,7 +365,7 @@ function setupPreview(repl, contextSymbol, bufferSymbol, active) {
     }, () => callback(new ERR_INSPECTOR_NOT_AVAILABLE()));
   }
 
-  const showPreview = (noCompletion = false) => {
+  const showPreview = (showCompletion = true) => {
     // Prevent duplicated previews after a refresh.
     if (inputPreview !== null || !repl.isCompletionEnabled) {
       return;
@@ -382,7 +382,9 @@ function setupPreview(repl, contextSymbol, bufferSymbol, active) {
 
     // Add the autocompletion preview.
     const insertPreview = false;
-    !noCompletion && showCompletionPreview(repl.line, insertPreview);
+    if (showCompletion) {
+      showCompletionPreview(repl.line, insertPreview);
+    }
 
     // Do not preview if the command is buffered.
     if (repl[bufferSymbol]) {

diff --git a/lib/repl.js b/lib/repl.js
@@ -993,7 +993,8 @@ function REPLServer(prompt,
       clearPreview(key);
       if (!reverseSearch(d, key)) {
         ttyWrite(d, key);
-        showPreview(key.name === 'escape');
+        const showCompletionPreview = key.name !== 'escape';
+        showPreview(showCompletionPreview);
       }
       return;
     }