Skip to content

Commit

Permalink
tools?: refactor test-npm into shell script
Browse files Browse the repository at this point in the history
  • Loading branch information
Fishrock123 committed May 8, 2015
1 parent b97b96d commit 7dea3b6
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 13 deletions.
14 changes: 1 addition & 13 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -138,19 +138,7 @@ test-debugger: all
$(PYTHON) tools/test.py debugger

test-npm: $(NODE_EXE)
rm -rf npm-cache npm-tmp npm-prefix
mkdir npm-cache npm-tmp npm-prefix
cd deps/npm ; npm_config_cache="$(shell pwd)/npm-cache" \
npm_config_prefix="$(shell pwd)/npm-prefix" \
npm_config_tmp="$(shell pwd)/npm-tmp" \
../../$(NODE_EXE) cli.js install --ignore-scripts
cd deps/npm ; npm_config_cache="$(shell pwd)/npm-cache" \
npm_config_prefix="$(shell pwd)/npm-prefix" \
npm_config_tmp="$(shell pwd)/npm-tmp" \
../../$(NODE_EXE) cli.js run-script test-all && \
../../$(NODE_EXE) cli.js prune --prod && \
cd ../.. && \
rm -rf npm-cache npm-tmp npm-prefix
NODE_EXE=$(NODE_EXE) tools/test-npm.sh

test-npm-publish: $(NODE_EXE)
npm_package_config_publishtest=true ./$(NODE_EXE) deps/npm/test/run.js
Expand Down
36 changes: 36 additions & 0 deletions tools/test-npm.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
#!/bin/bash

set -e

# always change the working directory to the project's root directory
cd $(dirname $0)/..

# pass NODE_EXE from something like Makefile
# it should point to either ./node or ./node.exe, depending on the platform
if ! [ -n "$NODE_EXE" ]; then
echo "No node executable provided. Bailing." >&2
exit 0
fi

rm -rf test-npm
mkdir test-npm

# make a copy of deps/npm to run the tests on
cp -r deps/npm/ test-npm/

cd test-npm

# do a rm first just in case deps/npm contained these
rm -rf npm-cache npm-tmp npm-prefix
mkdir npm-cache npm-tmp npm-prefix

# these commands all require the same env variables, so run them as one
npm_config_cache="npm-cache" \
npm_config_prefix="npm-prefix" \
npm_config_tmp="npm-tmp" \
../$NODE_EXE cli.js install --ignore-scripts && \
../$NODE_EXE cli.js run-script test-all && \
../$NODE_EXE cli.js prune --prod

# clean up everything one single shot
cd .. && rm -rf test-npm

0 comments on commit 7dea3b6

Please sign in to comment.