Skip to content

Commit

Permalink
test: create test-ci, modify test-all, fix cpplint
Browse files Browse the repository at this point in the history
test: add test/addons to default test list

`make test-all` and `python tools/test.py` will now also run the addon
tests in test/addons.

test: remove test-npm from test-all make target

The test-npm target builds documentation, changes versioned files,
clutters the current working directory with artifacts, etc.  In short,
it doesn't seem quite ready for inclusion in `make test-all`.

test: add test-ci target, reduced test-all

Add a test-ci target that is like test-all minus the (slow) pummel and
gc test suites.

This is primarily intended for the continuous integration, where we want
decent coverage but don't want to wait for ages for tests to complete.

cpplint: add -license/copyright to default filters

Commit 3e1b1dd ("Remove excessive copyright/license boilerplate") trips
up the copyright boilerplate style check.  Disable it.

PR-URL: #314
Reviewed-By: Rod Vagg <rod@vagg.org>
  • Loading branch information
bnoordhuis authored and rvagg committed Jan 13, 2015
1 parent f767226 commit 7861ff4
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
4 changes: 3 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,13 @@ test-build: all build-addons

test-all: test-build test/gc/node_modules/weak/build/Release/weakref.node
$(PYTHON) tools/test.py --mode=debug,release
make test-npm

test-all-valgrind: test-build
$(PYTHON) tools/test.py --mode=debug,release --valgrind

test-ci: test-build
$(PYTHON) tools/test.py -J parallel sequential message addons

test-release: test-build
$(PYTHON) tools/test.py --mode=release

Expand Down
2 changes: 1 addition & 1 deletion tools/cpplint.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@
# flag. By default all errors are on, so only add here categories that should be
# off by default (i.e., categories that must be enabled by the --filter= flags).
# All entries here should start with a '-' or '+', as in the --filter= flag.
_DEFAULT_FILTERS = [ '-build/include_alpha' ]
_DEFAULT_FILTERS = [ '-build/include_alpha', '-legal/copyright' ]

# We used to check for high-bit characters, but after much discussion we
# decided those were OK, as long as they were in UTF-8 and didn't represent
Expand Down
1 change: 1 addition & 0 deletions tools/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -1357,6 +1357,7 @@ def ExpandCommand(args):
'pummel',
'message',
'internet',
'addons',
'gc',
'debugger',
]
Expand Down

0 comments on commit 7861ff4

Please sign in to comment.