url: use SetMethodNoSideEffect for url functions

nodejs · Feb 27, 2023 · 7440a78 · 7440a78
1 parent 32a3e47
commit 7440a78
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -311,9 +311,9 @@ void Initialize(Local<Object> target,
                 Local<Value> unused,
                 Local<Context> context,
                 void* priv) {
-  SetMethod(context, target, "parse", Parse);
-  SetMethod(context, target, "updateUrl", UpdateUrl);
-  SetMethod(context, target, "formatUrl", FormatUrl);
+  SetMethodNoSideEffect(context, target, "parse", Parse);
+  SetMethodNoSideEffect(context, target, "updateUrl", UpdateUrl);
+  SetMethodNoSideEffect(context, target, "formatUrl", FormatUrl);
 
   SetMethodNoSideEffect(context, target, "domainToASCII", DomainToASCII);
   SetMethodNoSideEffect(context, target, "domainToUnicode", DomainToUnicode);