src: remove unused guards around node-api reference

PR-URL: #38334 Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs · Sep 4, 2021 · 5c473bd · 5c473bd
1 parent f39d93a
commit 5c473bd
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/src/js_native_api_v8.cc b/src/js_native_api_v8.cc
@@ -627,9 +627,6 @@ v8::Local<v8::Value> Reference::Get() {
 }
 
 void Reference::Finalize(bool is_env_teardown) {
-  if (is_env_teardown) env_teardown_finalize_started_ = true;
-  if (!is_env_teardown && env_teardown_finalize_started_) return;
-
   // During env teardown, `~napi_env()` alone is responsible for finalizing.
   // Thus, we don't want any stray gc passes to trigger a second call to
   // `RefBase::Finalize()`. ClearWeak will ensure that even if the

diff --git a/src/js_native_api_v8.h b/src/js_native_api_v8.h
@@ -433,7 +433,6 @@ class Reference : public RefBase {
   static void SecondPassCallback(
       const v8::WeakCallbackInfo<SecondPassCallParameterRef>& data);
 
-  bool env_teardown_finalize_started_ = false;
   v8impl::Persistent<v8::Value> _persistent;
   SecondPassCallParameterRef* _secondPassParameter;
   bool _secondPassScheduled;