Skip to content

Commit 4b47d29

Browse files
alexkozyaddaleax
authored andcommitted
build: do not copy v8-inspector* headers ar part of install
These headers are exposed from V8 for embedder and should not be used by native addons. Fixes #22415 PR-URL: #22586 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent 21e8ce2 commit 4b47d29

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

tools/install.py

+9-1
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,14 @@ def files(action):
157157
headers(action)
158158

159159
def headers(action):
160+
def ignore_inspector_headers(files, dest):
161+
inspector_headers = [
162+
'deps/v8/include/v8-inspector.h',
163+
'deps/v8/include/v8-inspector-protocol.h'
164+
]
165+
files = filter(lambda name: name not in inspector_headers, files)
166+
action(files, dest)
167+
160168
action([
161169
'common.gypi',
162170
'config.gypi',
@@ -172,7 +180,7 @@ def headers(action):
172180
if sys.platform.startswith('aix'):
173181
action(['out/Release/node.exp'], 'include/node/')
174182

175-
subdir_files('deps/v8/include', 'include/node/', action)
183+
subdir_files('deps/v8/include', 'include/node/', ignore_inspector_headers)
176184

177185
if 'false' == variables.get('node_shared_libuv'):
178186
subdir_files('deps/uv/include', 'include/node/', action)

0 commit comments

Comments
 (0)