Repository navigation
inspector: mark v8-inspector.h as NODE_WANT_INTERNALS #22415
Description
Activity
+1. Since the intent was for the header to be available to the Node, but not native modules, this makes sense to me. I don't suspect there is any user-space use of
v8-inspector.hat this point.Just saw this now. Awesome.
Hi, this affected my project isolated-vm. I'm invoking v8's isolate API directly to create pure JS isolated sandboxes which can be accessed via nodejs. My project includes support for the inspector so I do need these header files. For now I'll be forced to copy these files to my repository and distribute them on npm to keep my build operational.
With regards to the original problem of the ticket, that ABI compatibility is slowing down the nodejs team, I would like to point out that ABI compatibility is not an issue for my project. Perhaps the build process could stick these in a
nodejs-abi-unstabledirectory for me to pick up?- added a commit that references this issue
on Nov 19, 2018 I run into this problem too. Node.js can actually act as a v8 runtime. Without the two headers, you can't play with the inspector api.
- added a commit that references this issue
on Jul 27, 2026
Is your feature request related to a problem? Please describe.
V8 Inspector exposes API for Node.js. This API should be implemented by V8 embedder to enable inspector features. v8-inspector.h contains the most significant part of this API. Sometimes we need to fix some problems / backport some features which require little changes in v8-inspector.h file.
Right now any changes like this are blocked since we need to maintain ABI compatibility for all header files inside v8/includes folder.
Describe the solution you'd like
We can mark v8-inspector.h header with
NODE_WANT_INTERNALSmacro or with some intermediate more generic macro that in node will be synonym ofNODE_WANT_INTERNALS.If some methods or classes may be useful for native modules, we can expose them using separate header.