fixup! update to ERR_INVALID_STATE

nodejs · Jun 8, 2023 · 48a8af4 · 48a8af4
1 parent 845e322
commit 48a8af4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js
@@ -1272,7 +1272,8 @@ function readableStreamFromIterable(iterable) {
     const nextPromise = PromiseResolve(nextResult);
     return PromisePrototypeThen(nextPromise, (iterResult) => {
       if (typeof iterResult !== 'object' || iterResult === null) {
-        throw new ERR_INVALID_ARG_VALUE.TypeError('iterResult', iterResult);
+        throw new ERR_INVALID_STATE.TypeError(
+          'The promise returned by the iterator.next() method must fulfill with an object');
       }
       const done = Boolean(iterResult.done);
       if (done) {
@@ -1303,7 +1304,8 @@ function readableStreamFromIterable(iterable) {
     const returnPromise = PromiseResolve(returnResult);
     return PromisePrototypeThen(returnPromise, (iterResult) => {
       if (typeof iterResult !== 'object' || iterResult === null) {
-        throw new ERR_INVALID_ARG_VALUE.TypeError('iterResult', iterResult);
+        throw new ERR_INVALID_STATE.TypeError(
+          'The promise returned by the iterator.return() method must fulfill with an object');
       }
       return undefined;
     });

diff --git a/lib/internal/webstreams/util.js b/lib/internal/webstreams/util.js
@@ -22,6 +22,7 @@ const {
   codes: {
     ERR_INVALID_ARG_VALUE,
     ERR_OPERATION_FAILED,
+    ERR_INVALID_STATE,
   },
 } = require('internal/errors');
 
@@ -248,7 +249,7 @@ function getIterator(obj, kind = 'sync', method) {
 
   const iterator = FunctionPrototypeCall(method, obj);
   if (typeof iterator !== 'object' || iterator === null) {
-    throw new ERR_INVALID_ARG_VALUE.TypeError('iterator', iterator);
+    throw new ERR_INVALID_STATE.TypeError('The iterator method must return an object');
   }
   const nextMethod = iterator.next;
   return { iterator, nextMethod, done: false };
@@ -262,7 +263,7 @@ function iteratorNext(iteratorRecord, value) {
     result = FunctionPrototypeCall(iteratorRecord.nextMethod, iteratorRecord.iterator, [value]);
   }
   if (typeof result !== 'object' || result === null) {
-    throw new ERR_INVALID_ARG_VALUE.TypeError('iterator.next', result);
+    throw new ERR_INVALID_STATE.TypeError('The iterator.next() method must return an object');
   }
   return result;
 }