-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: add regression tests for HTTP parser crash
Since the tests only crash on v12.x, this commit adds separate regression tests. Refs: #15102 PR-URL: #34250 Refs: #34016 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
- Loading branch information
1 parent
afec0d7
commit 3ee8f53
Showing
1 changed file
with
53 additions
and
0 deletions.
There are no files selected for viewing
53 changes: 53 additions & 0 deletions
53
test/parallel/test-http-sync-write-error-during-continue.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const http = require('http'); | ||
const MakeDuplexPair = require('../common/duplexpair'); | ||
|
||
// Regression test for the crash reported in | ||
// https://github.com/nodejs/node/issues/15102 (httpParser.finish() is called | ||
// during httpParser.execute()): | ||
|
||
{ | ||
const { clientSide, serverSide } = MakeDuplexPair(); | ||
|
||
serverSide.on('data', common.mustCall((data) => { | ||
assert.strictEqual(data.toString('utf8'), `\ | ||
GET / HTTP/1.1 | ||
Expect: 100-continue | ||
Host: localhost:80 | ||
Connection: close | ||
`.replace(/\n/g, '\r\n')); | ||
|
||
setImmediate(() => { | ||
serverSide.write('HTTP/1.1 100 Continue\r\n\r\n'); | ||
}); | ||
})); | ||
|
||
const req = http.request({ | ||
createConnection: common.mustCall(() => clientSide), | ||
headers: { | ||
'Expect': '100-continue' | ||
} | ||
}); | ||
req.on('continue', common.mustCall((res) => { | ||
let sync = true; | ||
|
||
clientSide._writev = null; | ||
clientSide._write = common.mustCall((chunk, enc, cb) => { | ||
assert(sync); | ||
// On affected versions of Node.js, the error would be emitted on `req` | ||
// synchronously (i.e. before commit f663b31cc2aec), which would cause | ||
// parser.finish() to be called while we are here in the 'continue' | ||
// callback, which is inside a parser.execute() call. | ||
|
||
assert.strictEqual(chunk.length, 0); | ||
clientSide.destroy(new Error('sometimes the code just doesn’t work'), cb); | ||
}); | ||
req.on('error', common.mustCall()); | ||
req.end(); | ||
|
||
sync = false; | ||
})); | ||
} |