Skip to content

Commit 1918b4e

Browse files
Trotttargos
authored andcommitted
test: correct header length subtraction
In test-http-max-http-headers, a comment asks why we are subtracting 32 from the length of the invalid-length-by-1 headers instead of just 1. Subtracting 1 seems to be correct and works. PR-URL: #30712 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 1222be8 commit 1918b4e

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

test/sequential/test-http-max-http-headers.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ function fillHeaders(headers, currentSize, valid = false) {
3737

3838
// Generate valid headers
3939
if (valid) {
40-
// TODO(mcollina): understand why -32 is needed instead of -1
41-
headers = headers.slice(0, -32);
40+
headers = headers.slice(0, -1);
4241
}
4342
return headers + '\r\n\r\n';
4443
}

0 commit comments

Comments
 (0)