You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds verbose reasons to the documentation on why the
Reviewed-By metadata on a pull request is important.
This was loosely mentioned as an issue in the referenced
issue below, and answered by @addaleax.
Ref: #8893
change wording on documentation update
Changes the initial commit to the recommended, and more
accurate wording.
Removed time qualifiers on documentation for git merge
removes the ugly wording
add a new reason why autosquashing is prohibited
Copy file name to clipboardExpand all lines: doc/onboarding.md
+4-3Lines changed: 4 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -167,10 +167,11 @@ onboarding session.
167
167
* Please never use GitHub's green ["Merge Pull Request"](https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-using-the-github-web-interface) button.
168
168
* If you do, please force-push removing the merge.
169
169
* Reasons for not using the web interface button:
170
-
* The old merge method will write an ugly commit message.
171
-
* The old rebase & merge method adds metadata to the commit title.
172
-
* The latest rebase method changes the author.
170
+
* The merge method will add an unnecessary merge commit.
171
+
* The rebase & merge method adds metadata to the commit title.
172
+
* The rebase method changes the author.
173
173
* The squash & merge method has been known to add metadata to the commit title.
174
+
* If more than one author has contributed to the PR, only the latest author will be considered during the squashing.
174
175
175
176
176
177
Update your `master` branch (or whichever branch you are landing on, almost always `master`)
0 commit comments