squash: expand fs-read-optional test

nodejs · Apr 17, 2022 · 0bd9de7 · 0bd9de7
1 parent 71f03ce
commit 0bd9de7
Showing 1 changed file with 25 additions and 8 deletions.
diff --git a/test/parallel/test-fs-read-optional-params.js b/test/parallel/test-fs-read-optional-params.js
@@ -9,28 +9,45 @@ const fd = fs.openSync(filepath, 'r');
 
 const expected = Buffer.from('xyz\n');
 const defaultBufferAsync = Buffer.alloc(16384);
-const bufferAsOption = Buffer.allocUnsafe(expected.length);
+const bufferAsOption = Buffer.allocUnsafe(expected.byteLength);
 
 // Test not passing in any options object
 fs.read(fd, common.mustCall((err, bytesRead, buffer) => {
-  assert.strictEqual(bytesRead, expected.length);
-  assert.deepStrictEqual(defaultBufferAsync.length, buffer.length);
+  assert.strictEqual(bytesRead, expected.byteLength);
+  assert.deepStrictEqual(defaultBufferAsync.byteLength, buffer.byteLength);
+}));
+fs.read(fd, bufferAsOption, { position: 0 }, common.mustCall((err, bytesRead, buffer) => {
+  assert.strictEqual(bytesRead, expected.byteLength);
+  assert.deepStrictEqual(bufferAsOption.byteLength, buffer.byteLength);
 }));
 
 // Test passing in an empty options object
 fs.read(fd, { position: 0 }, common.mustCall((err, bytesRead, buffer) => {
-  assert.strictEqual(bytesRead, expected.length);
-  assert.deepStrictEqual(defaultBufferAsync.length, buffer.length);
+  assert.strictEqual(bytesRead, expected.byteLength);
+  assert.deepStrictEqual(defaultBufferAsync.byteLength, buffer.byteLength);
+}));
+fs.read(fd, bufferAsOption, { position: 0 }, common.mustCall((err, bytesRead, buffer) => {
+  assert.strictEqual(bytesRead, expected.byteLength);
+  assert.deepStrictEqual(bufferAsOption.byteLength, buffer.byteLength);
 }));
 
 // Test passing in options
 fs.read(fd, {
   buffer: bufferAsOption,
   offset: 0,
-  length: bufferAsOption.length,
+  length: bufferAsOption.byteLength,
+  position: 0
+},
+        common.mustCall((err, bytesRead, buffer) => {
+          assert.strictEqual(bytesRead, expected.byteLength);
+          assert.deepStrictEqual(bufferAsOption.byteLength, buffer.byteLength);
+        }));
+fs.read(fd, bufferAsOption, {
+  offset: 0,
+  length: bufferAsOption.byteLength,
   position: 0
 },
         common.mustCall((err, bytesRead, buffer) => {
-          assert.strictEqual(bytesRead, expected.length);
-          assert.deepStrictEqual(bufferAsOption.length, buffer.length);
+          assert.strictEqual(bytesRead, expected.byteLength);
+          assert.deepStrictEqual(bufferAsOption.byteLength, buffer.byteLength);
         }));