Skip to content

Commit b8366ae

Browse files
StefanStojanovicnodejs-github-bot
authored andcommitted
deps: define V8_PRESERVE_MOST as no-op on Windows
It's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools PR-URL: nodejs/node#56238 Refs: nodejs/node#55784 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
1 parent 5a94cfb commit b8366ae

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.2',
41+
'v8_embedder_string': '-node.3',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/include/v8config.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -605,11 +605,15 @@ path. Add it with -I<path> to the command line
605605
// functions.
606606
// Use like:
607607
// V8_NOINLINE V8_PRESERVE_MOST void UnlikelyMethod();
608+
#if V8_OS_WIN
609+
# define V8_PRESERVE_MOST
610+
#else
608611
#if V8_HAS_ATTRIBUTE_PRESERVE_MOST
609612
# define V8_PRESERVE_MOST __attribute__((preserve_most))
610613
#else
611614
# define V8_PRESERVE_MOST /* NOT SUPPORTED */
612615
#endif
616+
#endif
613617

614618

615619
// A macro (V8_DEPRECATED) to mark classes or functions as deprecated.

0 commit comments

Comments
 (0)