This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
V0.4 #774
Closed
V0.4 #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks |
|
without this the server will not advertise support for client certs Closed by 2a61e1c. |
coolaj86
pushed a commit
that referenced
this pull request
Apr 15, 2011
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client certificate validation stuff works, but most clients will refuse to send a cert unless they have one that is signed by one of the server advertised client CAs. So, while the server would validate if the client force-sended it, this is needed to get most clients to actually send the client cert up. It has no affect on client ssl contexts, so it doesn't need to be conditionally called only in server mode.